Conversation
chtruong814
left a comment
chtruong814
left a comment
There was a problem hiding this comment.
Thanks for this. Had some comments around the naming. Feel free to manually take care of that here but ideally we also clean up the template too.
vfm/package_info.py
Outdated
| __version__ = ".".join(map(str, VERSION[:3])) + "".join(VERSION[3:]) | ||
|
|
||
| __package_name__ = "vfm" | ||
| __contact_names__ = "VFM" |
There was a problem hiding this comment.
Sorry, I should have made the template better. Could you update the template so that __contact_names__ = "NVIDIA"?
vfm/package_info.py
Outdated
|
|
||
| __package_name__ = "vfm" | ||
| __contact_names__ = "VFM" | ||
| __contact_emails__ = "contact@example.com" |
There was a problem hiding this comment.
Let's update template so this is __contact_emails__ = "nemo-toolkit@nvidia.com" for now. I can double check later if we should be using something different.
vfm/__init__.py
Outdated
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| from vfm.package_info import ( |
There was a problem hiding this comment.
When using the cookie cutter template, instead of just vfm, let's have project name be NeMo VFM. The repo name will just be VFM. But the package and project would be referenced as NeMo VFM or nemo_vfm, etc...
chtruong814
left a comment
chtruong814
left a comment
There was a problem hiding this comment.
Sorry, we're not terribly consistent on the copyright in the template. Would you please resolve those and we can go ahead and get this merged?
nemo_vfm/__init__.py
Outdated
| @@ -0,0 +1,26 @@ | |||
| # Copyright (c) 2025, NeMo VFM. | |||
There was a problem hiding this comment.
Sorry, the template must be wrong here. Could you review the copyright in the template to make sure it's set to
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
nemo_vfm/package_info.py
Outdated
| @@ -0,0 +1,35 @@ | |||
| # Copyright (c) 2025, NeMo VFM. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
tests/unit_tests/test_placeholder.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| # Copyright (c) 2025, NeMo VFM. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
| @@ -0,0 +1,14 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
| @@ -0,0 +1,14 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
| @@ -0,0 +1,38 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
.github/workflows/cicd-main.yml
Outdated
| @@ -0,0 +1,252 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
| @@ -0,0 +1,40 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
| @@ -0,0 +1,83 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
| @@ -0,0 +1,251 @@ | |||
| # Copyright (c) 2025, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Another place to be updating the copyright template
Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION. All rights reserved.
2 participants
No description provided.