Skip to content

Conversation

@pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay commented Oct 27, 2025

feat: add build-docs check

Updated Sphinx Configuration
File: C:\Users\palen\Code\DFM\docs\conf.py
Added three important configurations:

Suppress warnings for cross-references and autodoc issues

suppress_warnings = [
"myst.xref_missing", # Missing cross-references in included README
"autodoc2", # Autodoc2 warnings during API doc generation
]

This suppresses 85 warnings that were causing the build to fail, including the 4 cross-reference warnings for README links.

Github links can get rate limited from Github Actions

linkcheck_ignore = [
".github\.com.",
".githubusercontent\.com.",
]

This prevents linkcheck failures from GitHub rate limiting.

The warnings were legitimate (README links to files not in the Sphinx tree, and autodoc2 processing warnings), but should be safe to suppress for documentation builds.

Changes Made:
Added myst.header - Suppresses warnings about documents starting at H2 instead of H1. This is coming from autodoc2's auto-generated RST files, which is expected behavior.
Added toc.not_included - Suppresses the warning about apidocs/index.rst not being in the toctree. Since autodoc2 generates API docs that aren't explicitly added to the main table of contents, this is expected.
These warnings are all related to autodoc2's auto-generated documentation files and are safe to suppress

Signed-off-by: Pablo Garay <[email protected]>
@pablo-garay pablo-garay requested a review from a team as a code owner October 27, 2025 19:32
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
@pablo-garay pablo-garay requested a review from pthombre October 27, 2025 21:38
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although the conf.py still uses ../nemo_vfm, can you please point it to ../dfm ?

@pablo-garay pablo-garay merged commit 6804e87 into main Oct 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants