Merged
Conversation
- Added comments to clarify file purposes in example_commands.sh, inference_wan.py, pretrain_wan.py, wan_provider.py, wan_step.py, and wan.py. - Introduced EnergonMultiModalDataModule for handling multimodal datasets in nemo_vfm. - Created SequentialMegatronSampler for efficient sequential sampling in large datasets. - Added new files for DIT attention and base data handling. This commit enhances documentation and introduces new functionalities for better data management and processing.
abhinavg4
requested changes
Nov 4, 2025
Contributor
abhinavg4
left a comment
abhinavg4
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR. I think a bunch of changes need to be done. Especially please remove all the debugging stuff and add copyright headers. Thanks a lot.
dfm/src/megatron/data/dit/utils.py
Outdated
| return cropped_tensor | ||
|
|
||
|
|
||
| def test_no_cropping_needed(): |
Contributor
There was a problem hiding this comment.
Can you remove these tests and move them to the tests folder?
Contributor
Author
There was a problem hiding this comment.
I would refrain from modifying DiT's related data code.
I would leave that for Sajad, so he can have an overall view of what is edited for DiT.
This file is in this PR only because diffusion_energon_datamodule.py is needed for Wan data energon.
Contributor
There was a problem hiding this comment.
hey, DiT does not use minimal_crop, so this file is not present in my final branch. I think this comment has to be addressed on this branch.
added 13 commits
November 4, 2025 23:52
Contributor
Author
|
/ok to test 13968fc |
pablo-garay
reviewed
Nov 12, 2025
| "Topic :: Utilities", | ||
| ] | ||
| dependencies = [ | ||
| "diffusers==0.35.1", |
Contributor
There was a problem hiding this comment.
These (new lines for) dependencies were already added below in this pyproject.toml file, hence i think we dont need to add them here anymore
Contributor
Author
|
/ok to test b1c41fc |
Contributor
|
/ok to test d8bcade |
pablo-garay
force-pushed
the
huvu/mcore_wan
branch
from
d8bcade to
681145b
Compare
Contributor
|
/ok to test 681145b |
pablo-garay
approved these changes
Nov 12, 2025
huvunvidia
added a commit
that referenced
this pull request
Feb 12, 2026
* first commit * workable code * workable thd * clean up, remove all CP for sbhd, CP now is only for thd * run outside of Mbridge * Update example scripts and add new data module for multimodal datasets - Added comments to clarify file purposes in example_commands.sh, inference_wan.py, pretrain_wan.py, wan_provider.py, wan_step.py, and wan.py. - Introduced EnergonMultiModalDataModule for handling multimodal datasets in nemo_vfm. - Created SequentialMegatronSampler for efficient sequential sampling in large datasets. - Added new files for DIT attention and base data handling. This commit enhances documentation and introduces new functionalities for better data management and processing. * workable code before refactoring * refactor attention submodules + reorder files locations * update refactor * update refactor * reorganize files * reorganize files * refactoring code * add README for perf test * using vae, t5, scheduler from Diffusers * update repo, remove Wan's Github moduels * fix Ruff * fix ruff + copyright * fix Ruff + Lint * fix Ruff + Lint * fix Ruff + Lint * fix Ruff + Lint * fix Ruff + Lint * fix Ruff + Lint * fix Ruff + Lint * fix Ruff + Lint * merged main + address comments * remove example_commands.md, Google waits until mid Nov * refactor inference_configs + mockdatamodule * add dit_embeddings.py * fix lint ruff * add 'average_gradients_across_tp_domain' to torch.nn for when running sequence_parallelism * add english negative prompt * fix ruff lint * Update uv.lock for deps: diffusers==0.35.1, easydict, imageio * update dfm/src/megatron/data/dit * change english negative prompt * seem to workable seq_packing * refactor with Sajad's PR - DiT data to common dir * fix Ruff, lint * fix Ruff, lint * fix Ruff, lint * workable mock datamodule (doesn't need setting path); updated training algo + hyper-parameters aligning with Linnan; tested training with anime dataset finetung * bring wan_task encoders features to common, sharing with dit * lint, ruff * lint, ruff * lint, ruff * fix CP error (input of thd_split_inputs_cp to be cu_seqlens_q_padded instead of cu_seqlens_q) * udpate README_perf_test.md * fix lint, ruff * update uv.lock, merge main * uv.lock * uv.lock * uv.lock * update uv.lock [using ci] --------- Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: Abhinav Garg <abhinavg@stanford.edu> Co-authored-by: root <root@eos0025.eos.clusters.nvidia.com> Co-authored-by: root <root@eos0558.eos.clusters.nvidia.com> Co-authored-by: Pablo Garay <pagaray@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.