tests: add more logs #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Garay <[email protected]>
Collaborator
Author
|
/ok to test eb967b5 |
chtruong814
reviewed
Nov 20, 2025
Collaborator
chtruong814
left a comment
chtruong814
left a comment
There was a problem hiding this comment.
Some comments to refactor the code.
| except subprocess.CalledProcessError as e: | ||
| pytest.fail(f"WAN pretrain mock run failed with return code {e.returncode}") | ||
| print("STDOUT:", e.stdout) | ||
| print("STDERR:", e.stderr) |
Collaborator
There was a problem hiding this comment.
It seems like you want to print out the stdout and stderr regardless? If that's the case, better to do that in a finally block and remove lines 95 and 96. That way, whether it fails or succeeds, you print the stdout and stderr
| except subprocess.CalledProcessError as e: | ||
| pytest.fail(f"DiT pretrain mock run failed with return code {e.returncode}") | ||
| print("STDOUT:", e.stdout) | ||
| print("STDERR:", e.stderr) |
Collaborator
There was a problem hiding this comment.
It seems like you want to print out the stdout and stderr regardless? If that's the case, better to do that in a finally block and remove lines 77 and 78. That way, whether it fails or succeeds, you print the stdout and stderr
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Collaborator
Author
|
/ok to test 882194d |
chtruong814
approved these changes
Nov 20, 2025
sajadn
pushed a commit
that referenced
this pull request
Nov 20, 2025
* tests: add more logs Signed-off-by: Pablo Garay <[email protected]> * update Signed-off-by: Pablo Garay <[email protected]> * update2 Signed-off-by: Pablo Garay <[email protected]> --------- Signed-off-by: Pablo Garay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.