Skip to content

Enhance DiT and Wan mock data modules by initializing training data l… #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhinavg4 merged 3 commits into from
Nov 20, 2025
Merged

Enhance DiT and Wan mock data modules by initializing training data l… #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e92599
Enhance DiT and Wan mock data modules by initializing training data l…
abhinavg4 Nov 20, 2025
4177d06
Remove unnecessary DataLoader assertion from Wan mock datamodule test…
abhinavg4 Nov 20, 2025
0938288
Merge branch 'main' into dit_fix
abhinavg4 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dfm/src/megatron/data/dit/dit_mock_datamodule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ def __post_init__(self):
shuffle=False,
drop_last=False,
)
self._train_dl = iter(self._train_dl)
self.sequence_length = self.seq_length

def build_datasets(self, _context: DatasetBuildContext):
Expand Down
1 change: 1 addition & 0 deletions dfm/src/megatron/data/wan/wan_mock_datamodule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def __post_init__(self):
shuffle=False,
drop_last=False,
)
self._train_dl = iter(self._train_dl)
self.sequence_length = self.seq_length

def build_datasets(self, _context: DatasetBuildContext):
Expand Down
2 changes: 2 additions & 0 deletions tests/functional_tests/mcore/recipes/test_dit_pretrain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ def test_DiT_pretrain_mock(self, tmp_path):
"model.context_parallel_size=1",
"model.qkv_format=thd",
"model.num_attention_heads=16",
f"checkpoint.save={checkpoint_dir}",
f"checkpoint.load={checkpoint_dir}",
"dataset.task_encoder_seq_length=4608",
"dataset.seq_length=4608",
"train.global_batch_size=2",
Expand Down
2 changes: 0 additions & 2 deletions tests/unit_tests/megatron/data/wan/test_wan_mock_datamodule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# limitations under the License.

import torch
from torch.utils.data import DataLoader

from dfm.src.megatron.data.wan.wan_mock_datamodule import WanMockDataModuleConfig

Expand All @@ -37,7 +36,6 @@ def test_wan_mock_datamodule_build_and_batch_shapes():
context_embeddings_dim=64,
)
train_dl, val_dl, test_dl = cfg.build_datasets(_context=None)
assert isinstance(train_dl, DataLoader)
assert train_dl is val_dl and val_dl is test_dl

batch = next(iter(train_dl))
Expand Down