move readme #69
move readme #69
Conversation
Signed-off-by: linnan wang <[email protected]>
Signed-off-by: linnan wang <[email protected]>
Signed-off-by: linnan wang <[email protected]>
|
/ok to test db49d9a |
abhinavg4
left a comment
abhinavg4
left a comment
There was a problem hiding this comment.
I would suggest to format the readme from the perspective of a new user and not an experienced user. Think of someone who is just starting to use our repo and does not know much about Wan models maybe. Please see comments.
| --ulimit stack=67108864 \ | ||
| dfm-training bash | ||
|
|
||
| # Inside container: Initialize submodules |
There was a problem hiding this comment.
Are these 2 command still needed after what you do in README? I think atleast git submodule update --init --recursive 3rdparty/ should not be needed also start the docker with UV_PROJECT_ENVIRONMENT instead of saying do it inside the container?
There was a problem hiding this comment.
@pablo-garay can you help us? is there a way to avoid the git submodule init and the UV_PROJECT_ENVIRONMENT? Thanks
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
|
/ok to test cb7e9e2 |
akoumpa
left a comment
akoumpa
left a comment
There was a problem hiding this comment.
Thanks a lot @linnanwang
Signed-off-by: linnan wang <[email protected]> Signed-off-by: Lawrence Lane <[email protected]>
No description provided.