You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+60-57Lines changed: 60 additions & 57 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -88,94 +88,97 @@ Data Designer uses [`uv`](https://github.com/astral-sh/uv) for dependency manage
88
88
### Initial Setup
89
89
0.**Create or find an issue**
90
90
91
-
Before starting work, ensure there's an issue tracking your contribution:
92
-
- For bug fixes: Search [existing issues](https://github.com/NVIDIA-NeMo/DataDesigner/issues) or [create a new one](https://github.com/NVIDIA-NeMo/DataDesigner/issues/new)
93
-
- For new features: Open a [feature request](#feature-requests) to discuss the approach first
94
-
- Comment on the issue to let maintainers know you're working on it
91
+
Before starting work, ensure there's an issue tracking your contribution:
92
+
93
+
- For bug fixes: Search [existing issues](https://github.com/NVIDIA-NeMo/DataDesigner/issues) or [create a new one](https://github.com/NVIDIA-NeMo/DataDesigner/issues/new)
94
+
- For new features: Open a [feature request](#feature-requests) to discuss the approach first
95
+
- Comment on the issue to let maintainers know you're working on it
95
96
96
97
1.**Fork and clone the repository**
97
98
98
-
Start by [forking the Data Designer repository](https://github.com/NVIDIA-NeMo/DataDesigner/fork), then clone your fork and add the upstream remote:
99
+
Start by [forking the Data Designer repository](https://github.com/NVIDIA-NeMo/DataDesigner/fork), then clone your fork and add the upstream remote:
- `johnnygreco/feat/123-add-xyz-generator` for a new feature by @johnnygreco, addressing issue #123
148
151
149
152
2. **Develop your changes**
150
153
151
-
Please follow the patterns and conventions used throughout the codebase, as well as those outlined in [AGENTS.md](AGENTS.md).
154
+
Please follow the patterns and conventions used throughout the codebase, as well as those outlined in [AGENTS.md](AGENTS.md).
152
155
153
156
3. **Test and validate**
154
157
155
-
```bash
156
-
make check-all-fix # Format code and fix linting issues
157
-
make test# Run all tests
158
-
make coverage # Check test coverage (must be >90%)
159
-
```
158
+
```bash
159
+
make check-all-fix # Format code and fix linting issues
160
+
make test # Run all tests
161
+
make coverage # Check test coverage (must be >90%)
162
+
```
160
163
161
-
**Writing tests**: Place tests in [tests/](tests/) mirroring the source structure. Use fixtures from [tests/conftest.py](tests/conftest.py), mock external services with `unittest.mock` or `pytest-httpx`, and test both success and failure cases. See [AGENTS.md](AGENTS.md) for patterns and examples.
164
+
**Writing tests**: Place tests in [tests/](tests/) mirroring the source structure. Use fixtures from [tests/conftest.py](tests/conftest.py), mock external services with `unittest.mock` or `pytest-httpx`, and test both success and failure cases. See [AGENTS.md](AGENTS.md) for patterns and examples.
162
165
163
166
4. **Commit your work**
164
167
165
-
Write clear, descriptive commit messages, optionally including a brief summary (50 characters or less) and reference issue numbers when applicable (e.g., "Fixes #123").
168
+
Write clear, descriptive commit messages, optionally including a brief summary (50 characters or less) and reference issue numbers when applicable (e.g., "Fixes #123").
0 commit comments