Skip to content

Commit 21ec195

Browse files
authored
fix: markdown formatting to make MkDocs happy (#59)
* fix: markdown formatting to make MkDocs happy * fix contributing guide link in README
1 parent 1d5d51e commit 21ec195

File tree

2 files changed

+61
-58
lines changed

2 files changed

+61
-58
lines changed

CONTRIBUTING.md

Lines changed: 60 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -88,94 +88,97 @@ Data Designer uses [`uv`](https://github.com/astral-sh/uv) for dependency manage
8888
### Initial Setup
8989
0. **Create or find an issue**
9090

91-
Before starting work, ensure there's an issue tracking your contribution:
92-
- For bug fixes: Search [existing issues](https://github.com/NVIDIA-NeMo/DataDesigner/issues) or [create a new one](https://github.com/NVIDIA-NeMo/DataDesigner/issues/new)
93-
- For new features: Open a [feature request](#feature-requests) to discuss the approach first
94-
- Comment on the issue to let maintainers know you're working on it
91+
Before starting work, ensure there's an issue tracking your contribution:
92+
93+
- For bug fixes: Search [existing issues](https://github.com/NVIDIA-NeMo/DataDesigner/issues) or [create a new one](https://github.com/NVIDIA-NeMo/DataDesigner/issues/new)
94+
- For new features: Open a [feature request](#feature-requests) to discuss the approach first
95+
- Comment on the issue to let maintainers know you're working on it
9596

9697
1. **Fork and clone the repository**
9798

98-
Start by [forking the Data Designer repository](https://github.com/NVIDIA-NeMo/DataDesigner/fork), then clone your fork and add the upstream remote:
99+
Start by [forking the Data Designer repository](https://github.com/NVIDIA-NeMo/DataDesigner/fork), then clone your fork and add the upstream remote:
99100

100-
```bash
101-
git clone https://github.com/YOUR_GITHUB_USERNAME/DataDesigner.git
101+
```bash
102+
git clone https://github.com/YOUR_GITHUB_USERNAME/DataDesigner.git
102103

103-
cd DataDesigner
104+
cd DataDesigner
104105

105-
git remote add upstream https://github.com/NVIDIA-NeMo/DataDesigner.git
106-
```
106+
git remote add upstream https://github.com/NVIDIA-NeMo/DataDesigner.git
107+
```
107108

108109
2. **Install dependencies**
109110

110-
```bash
111-
# Install project with dev dependencies
112-
make install-dev
111+
```bash
112+
# Install project with dev dependencies
113+
make install-dev
113114
114-
# Or, if you use Jupyter / IPython for development
115-
make install-dev-notebooks
116-
```
115+
# Or, if you use Jupyter / IPython for development
116+
make install-dev-notebooks
117+
```
117118

118119
3. **Verify your setup**
119120

120-
```bash
121-
make test && make check-all
122-
```
121+
```bash
122+
make test && make check-all
123+
```
123124

124-
If no errors are reported, you're ready to develop 🚀
125+
If no errors are reported, you're ready to develop 🚀
125126
126127
### Making Changes
127128
128129
1. **Create a feature branch**
129130
130-
```bash
131-
git checkout main
132-
git pull upstream main
133-
git checkout -b <username>/<type-of-change>/<issue-number>-<short-description>
134-
```
135-
136-
Example types of change:
137-
- `feat` for new features
138-
- `fix` for bug fixes
139-
- `docs` for documentation updates
140-
- `test` for testing changes
141-
- `refactor` for code refactoring
142-
- `chore` for chore tasks
143-
- `style` for style changes
144-
- `perf` for performance improvements
145-
146-
Example branch name:
147-
- `johnnygreco/feat/123-add-xyz-generator` for a new feature by @johnnygreco, addressing issue #123
131+
```bash
132+
git checkout main
133+
git pull upstream main
134+
git checkout -b <username>/<type-of-change>/<issue-number>-<short-description>
135+
```
136+
137+
Example types of change:
138+
139+
- `feat` for new features
140+
- `fix` for bug fixes
141+
- `docs` for documentation updates
142+
- `test` for testing changes
143+
- `refactor` for code refactoring
144+
- `chore` for chore tasks
145+
- `style` for style changes
146+
- `perf` for performance improvements
147+
148+
Example branch name:
149+
150+
- `johnnygreco/feat/123-add-xyz-generator` for a new feature by @johnnygreco, addressing issue #123
148151
149152
2. **Develop your changes**
150153
151-
Please follow the patterns and conventions used throughout the codebase, as well as those outlined in [AGENTS.md](AGENTS.md).
154+
Please follow the patterns and conventions used throughout the codebase, as well as those outlined in [AGENTS.md](AGENTS.md).
152155
153156
3. **Test and validate**
154157
155-
```bash
156-
make check-all-fix # Format code and fix linting issues
157-
make test # Run all tests
158-
make coverage # Check test coverage (must be >90%)
159-
```
158+
```bash
159+
make check-all-fix # Format code and fix linting issues
160+
make test # Run all tests
161+
make coverage # Check test coverage (must be >90%)
162+
```
160163
161-
**Writing tests**: Place tests in [tests/](tests/) mirroring the source structure. Use fixtures from [tests/conftest.py](tests/conftest.py), mock external services with `unittest.mock` or `pytest-httpx`, and test both success and failure cases. See [AGENTS.md](AGENTS.md) for patterns and examples.
164+
**Writing tests**: Place tests in [tests/](tests/) mirroring the source structure. Use fixtures from [tests/conftest.py](tests/conftest.py), mock external services with `unittest.mock` or `pytest-httpx`, and test both success and failure cases. See [AGENTS.md](AGENTS.md) for patterns and examples.
162165
163166
4. **Commit your work**
164167
165-
Write clear, descriptive commit messages, optionally including a brief summary (50 characters or less) and reference issue numbers when applicable (e.g., "Fixes #123").
168+
Write clear, descriptive commit messages, optionally including a brief summary (50 characters or less) and reference issue numbers when applicable (e.g., "Fixes #123").
166169
167-
```bash
168-
git commit -m "Add XYZ generator for synthetic data" -m "Fixes #123"
169-
```
170+
```bash
171+
git commit -m "Add XYZ generator for synthetic data" -m "Fixes #123"
172+
```
170173
171174
5. **Stay up to date**
172175
173-
Regularly sync your branch with upstream changes:
176+
Regularly sync your branch with upstream changes:
174177
175-
```bash
176-
git fetch upstream
177-
git merge upstream/main
178-
```
178+
```bash
179+
git fetch upstream
180+
git merge upstream/main
181+
```
179182
180183
## Submitting Changes
181184
@@ -194,9 +197,9 @@ Ensure your changes meet the following criteria:
194197
195198
1. **Push your changes** to your fork:
196199
197-
```bash
198-
git push origin <username>/<type-of-change>/<issue-number>-<short-description>
199-
```
200+
```bash
201+
git push origin <username>/<type-of-change>/<issue-number>-<short-description>
202+
```
200203
201204
2. **Open a pull request** on GitHub from your fork to the main repository
202205

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ data-designer config list # View current settings
115115

116116
### 🤝 Get involved
117117

118-
- **[Contributing Guide](https://nvidia-nemo.github.io/DataDesigner/CONTRIBUTING.md)** – Help improve Data Designer
118+
- **[Contributing Guide](https://nvidia-nemo.github.io/DataDesigner/CONTRIBUTING)** – Help improve Data Designer
119119
- **[GitHub Issues](https://github.com/NVIDIA-NeMo/DataDesigner/issues)** – Report bugs or make a feature request
120120

121121
---

0 commit comments

Comments
 (0)