Skip to content

Commit 36fc511

Browse files
committed
it works! cleaning up
1 parent 18103b1 commit 36fc511

File tree

3 files changed

+20
-13
lines changed

3 files changed

+20
-13
lines changed

.github/workflows/pack-tutorials.yml

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ name: Pack Tutorials
22

33
on:
44
workflow_dispatch:
5-
push:
5+
release:
6+
types: [published]
67

78
jobs:
89
zip_and_upload:
@@ -24,7 +25,7 @@ jobs:
2425
- name: Check if source folder exists
2526
run: |
2627
if [ ! -d "${{ env.SOURCE_FOLDER_PATH }}" ]; then
27-
echo "::error::Source Folder '${{ env.SOURCE_FOLDER_PATH }}' not found. Check the input value."
28+
echo "::error::Source folder '${{ env.SOURCE_FOLDER_PATH }}' not found. Check the input value."
2829
exit 1
2930
fi
3031
@@ -36,20 +37,26 @@ jobs:
3637
zip -r ${{ env.ZIP_FILE_NAME }} ${{ env.TARGET_FOLDER_NAME }}
3738
echo "Successfully created ${{ env.ZIP_FILE_NAME }}"
3839
39-
- name: Find the latest existing release Tag
40+
- name: Find the latest existing release tag
4041
id: get_release
4142
run: |
42-
gh auth status || echo "GitHub CLI is not authenticated, relying on GITHUB_TOKEN."
43+
if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
44+
echo "::notice::Running manually via workflow_dispatch. Fetching latest release tag..."
4345
44-
# We use tr -d '\n' to remove the trailing newline for a clean tag string
45-
LATEST_TAG=$(gh release view --json tagName -q .tagName 2>/dev/null)
46-
47-
if [ -z "$LATEST_TAG" ]; then
48-
echo "::error::Could not find the latest published release tag. Ensure a release exists."
49-
exit 1
46+
gh auth status || echo "GitHub CLI is not authenticated, relying on GITHUB_TOKEN."
47+
48+
# We use tr -d '\n' to remove the trailing newline for a clean tag string
49+
LATEST_TAG=$(gh release view --json tagName -q .tagName 2>/dev/null)
50+
51+
if [ -z "$LATEST_TAG" ]; then
52+
echo "::error::Could not find the latest published release tag. Ensure a release exists."
53+
exit 1
54+
fi
55+
else
56+
LATEST_TAG="${{ github.event.release.tag_name }}"
5057
fi
5158
52-
echo "Latest Release Tag found: $LATEST_TAG"
59+
echo "Latest release tag found: $LATEST_TAG"
5360
echo "tag=$LATEST_TAG" >> $GITHUB_OUTPUT
5461
env:
5562
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

docs/notebooks/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Welcome to the Data Designer tutorial series! These hands-on notebooks will guid
66

77
### Local Setup Best Practices
88

9-
First, download the tutorial [from the release assets](add-link).
9+
First, download the tutorial [from the release assets](https://github.com/NVIDIA-NeMo/DataDesigner/releases/latest/download/data_designer_tutorial.zip).
1010
To run them locally, we recommend using a virtual environment to manage dependencies:
1111

1212
=== "uv (Recommended)"

docs/notebooks/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ version = "0.1.0"
44
readme = "README.md"
55
requires-python = ">=3.11"
66
dependencies = [
7-
"data-designer==0.1.0",
7+
"data-designer>=0.1.0",
88
"jupyter>=1.1.1",
99
]

0 commit comments

Comments
 (0)