Skip to content

Commit 4bccea7

Browse files
committed
builtin -> default; move adding plugins to registry
1 parent cd4183b commit 4bccea7

File tree

8 files changed

+28
-27
lines changed

8 files changed

+28
-27
lines changed

src/data_designer/engine/analysis/column_profilers/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
class ColumnProfilerRegistry(TaskRegistry[ColumnProfilerType, ColumnProfiler, ConfigBase]): ...
1515

1616

17-
def create_builtin_column_profiler_registry() -> ColumnProfilerRegistry:
17+
def create_default_column_profiler_registry() -> ColumnProfilerRegistry:
1818
registry = ColumnProfilerRegistry()
1919
registry.register(ColumnProfilerType.JUDGE_SCORE, JudgeScoreProfiler, JudgeScoreProfilerConfig, False)
2020
return registry

src/data_designer/engine/column_generators/registry.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,14 @@
2727
SeedDatasetMultiColumnConfig,
2828
)
2929
from data_designer.engine.registry.base import TaskRegistry
30+
from data_designer.plugins.plugin import PluginType
31+
from data_designer.plugins.registry import PluginRegistry
3032

3133

3234
class ColumnGeneratorRegistry(TaskRegistry[DataDesignerColumnType, ColumnGenerator, ConfigBase]): ...
3335

3436

35-
def create_builtin_column_generator_registry() -> ColumnGeneratorRegistry:
37+
def create_default_column_generator_registry(with_plugins: bool = True) -> ColumnGeneratorRegistry:
3638
registry = ColumnGeneratorRegistry()
3739
registry.register(DataDesignerColumnType.LLM_TEXT, LLMTextCellGenerator, LLMTextColumnConfig)
3840
registry.register(DataDesignerColumnType.LLM_CODE, LLMCodeCellGenerator, LLMCodeColumnConfig)
@@ -42,4 +44,13 @@ def create_builtin_column_generator_registry() -> ColumnGeneratorRegistry:
4244
registry.register(DataDesignerColumnType.SEED_DATASET, SeedDatasetColumnGenerator, SeedDatasetMultiColumnConfig)
4345
registry.register(DataDesignerColumnType.VALIDATION, ValidationColumnGenerator, ValidationColumnConfig)
4446
registry.register(DataDesignerColumnType.LLM_STRUCTURED, LLMStructuredCellGenerator, LLMStructuredColumnConfig)
47+
48+
if with_plugins:
49+
for plugin in PluginRegistry().get_plugins(PluginType.COLUMN_GENERATOR):
50+
registry.register(
51+
DataDesignerColumnType(plugin.name),
52+
plugin.task_cls,
53+
plugin.config_cls,
54+
)
55+
4556
return registry

src/data_designer/engine/processing/processors/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
class ProcessorRegistry(TaskRegistry[str, Processor, ConfigBase]): ...
1515

1616

17-
def create_builtin_processor_registry() -> ProcessorRegistry:
17+
def create_default_processor_registry() -> ProcessorRegistry:
1818
registry = ProcessorRegistry()
1919
registry.register(ProcessorType.DROP_COLUMNS, DropColumnsProcessor, DropColumnsProcessorConfig, False)
2020
return registry

src/data_designer/engine/registry/data_designer_registry.py

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
# SPDX-License-Identifier: Apache-2.0
33

4-
from data_designer.config.column_types import DataDesignerColumnType
54
from data_designer.engine.analysis.column_profilers.registry import (
65
ColumnProfilerRegistry,
7-
create_builtin_column_profiler_registry,
6+
create_default_column_profiler_registry,
87
)
98
from data_designer.engine.column_generators.registry import (
109
ColumnGeneratorRegistry,
11-
create_builtin_column_generator_registry,
10+
create_default_column_generator_registry,
1211
)
13-
from data_designer.engine.processing.processors.registry import ProcessorRegistry, create_builtin_processor_registry
14-
from data_designer.plugins.plugin import PluginType
15-
from data_designer.plugins.registry import PluginRegistry
12+
from data_designer.engine.processing.processors.registry import ProcessorRegistry, create_default_processor_registry
1613

1714

1815
class DataDesignerRegistry:
@@ -23,16 +20,9 @@ def __init__(
2320
column_profiler_registry: ColumnProfilerRegistry | None = None,
2421
processor_registry: ProcessorRegistry | None = None,
2522
):
26-
self._column_generator_registry = column_generator_registry or create_builtin_column_generator_registry()
27-
self._column_profiler_registry = column_profiler_registry or create_builtin_column_profiler_registry()
28-
self._processor_registry = processor_registry or create_builtin_processor_registry()
29-
30-
for plugin in PluginRegistry().get_plugins(PluginType.COLUMN_GENERATOR):
31-
self._column_generator_registry.register(
32-
DataDesignerColumnType(plugin.name),
33-
plugin.task_cls,
34-
plugin.config_cls,
35-
)
23+
self._column_generator_registry = column_generator_registry or create_default_column_generator_registry()
24+
self._column_profiler_registry = column_profiler_registry or create_default_column_profiler_registry()
25+
self._processor_registry = processor_registry or create_default_processor_registry()
3626

3727
@property
3828
def column_generators(self) -> ColumnGeneratorRegistry:

tests/engine/analysis/test_errors.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
)
1111
from data_designer.engine.analysis.column_profilers.registry import (
1212
ColumnProfilerRegistry,
13-
create_builtin_column_profiler_registry,
13+
create_default_column_profiler_registry,
1414
)
1515
from data_designer.engine.registry.errors import NotFoundInRegistryError
1616

@@ -52,7 +52,7 @@ def test_get_nonexistent_profiler():
5252

5353

5454
def test_create_default_registry():
55-
registry = create_builtin_column_profiler_registry()
55+
registry = create_default_column_profiler_registry()
5656

5757
assert isinstance(registry, ColumnProfilerRegistry)
5858
assert ColumnProfilerType.JUDGE_SCORE in ColumnProfilerRegistry._registry

tests/engine/column_generators/test_registry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
from data_designer.engine.column_generators.generators.validation import ValidationColumnGenerator
1515
from data_designer.engine.column_generators.registry import (
1616
ColumnGeneratorRegistry,
17-
create_builtin_column_generator_registry,
17+
create_default_column_generator_registry,
1818
)
1919

2020

2121
def test_column_generator_registry_create_default_registry_with_generators():
22-
registry = create_builtin_column_generator_registry()
22+
registry = create_default_column_generator_registry()
2323

2424
assert isinstance(registry, ColumnGeneratorRegistry)
2525

tests/engine/processing/processors/test_registry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
from data_designer.engine.processing.processors.drop_columns import DropColumnsProcessor
66
from data_designer.engine.processing.processors.registry import (
77
ProcessorRegistry,
8-
create_builtin_processor_registry,
8+
create_default_processor_registry,
99
)
1010

1111

1212
def test_create_default_processor_registry():
13-
registry = create_builtin_processor_registry()
13+
registry = create_default_processor_registry()
1414

1515
assert isinstance(registry, ProcessorRegistry)
1616
assert ProcessorType.DROP_COLUMNS in ProcessorRegistry._registry

tests/engine/registry/test_data_designer_registry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ def stub_column_profiler_registry():
2121
@pytest.fixture
2222
def stub_default_registries():
2323
with patch(
24-
"data_designer.engine.registry.data_designer_registry.create_builtin_column_generator_registry"
24+
"data_designer.engine.registry.data_designer_registry.create_default_column_generator_registry"
2525
) as mock_gen:
2626
with patch(
27-
"data_designer.engine.registry.data_designer_registry.create_builtin_column_profiler_registry"
27+
"data_designer.engine.registry.data_designer_registry.create_default_column_profiler_registry"
2828
) as mock_prof:
2929
mock_gen_registry = Mock()
3030
mock_prof_registry = Mock()

0 commit comments

Comments
 (0)