Skip to content

Commit 804c0ef

Browse files
committed
pr feedback
1 parent 63852c9 commit 804c0ef

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,9 @@ Share your use cases! Example notebooks and tutorials help others understand how
6161
Help us improve test coverage by adding tests for untested code paths or edge cases.
6262

6363
## Feature Requests
64-
6564
Data Designer is designed to be as flexible and extensible as possible, and we welcome your ideas for pushing its capabilities even further! To keep the core library maintainable, while also supporting innovation, we take an incremental approach: we explore what's already possible, extend through plugins when needed, and integrate the most broadly useful features into the core library:
6665

6766
### How We Grow Data Designer
68-
6967
1. 🧗 **Explore what's possible**: Can your use case be achieved with current features? We've designed Data Designer to be composable – sometimes creative combinations of existing tools can accomplish what you need. Check out our examples or open an issue if you'd like help exploring this!
7068

7169
2. 🔌 **Extend through plugins**: If existing features aren't quite enough, consider implementing your idea as a plugin that extends the core library. Plugins let you experiment and share innovations while keeping the core focused.
@@ -75,7 +73,6 @@ Data Designer is designed to be as flexible and extensible as possible, and we w
7573
This approach helps us grow thoughtfully while keeping Data Designer reliable for everyone.
7674

7775
### Submitting a Feature Request
78-
7976
Open a [new issue](https://github.com/NVIDIA-NeMo/DataDesigner/issues/new) with:
8077

8178
- **Clear title**: Concise description of the feature
@@ -86,11 +83,9 @@ Open a [new issue](https://github.com/NVIDIA-NeMo/DataDesigner/issues/new) with:
8683
- **Willingness to implement**: Are you interested in implementing this yourself?
8784

8885
## Development Guide
89-
9086
Data Designer uses [`uv`](https://github.com/astral-sh/uv) for dependency management. If you don't have uv installed, follow their [installation instructions](https://docs.astral.sh/uv/getting-started/installation/).
9187

9288
### Initial Setup
93-
9489
0. **Create or find an issue**
9590

9691
Before starting work, ensure there's an issue tracking your contribution:
@@ -120,12 +115,6 @@ Data Designer uses [`uv`](https://github.com/astral-sh/uv) for dependency manage
120115
make install-dev-notebooks
121116
```
122117

123-
This creates a virtual environment in `.venv`. Activate it with:
124-
125-
```bash
126-
source .venv/bin/activate
127-
```
128-
129118
3. **Verify your setup**
130119

131120
```bash
@@ -223,13 +212,11 @@ Ensure your changes meet the following criteria:
223212
- Your contribution will be included in the next release!
224213

225214
## Code of Conduct
226-
227215
Data Designer follows the Contributor Covenant Code of Conduct. We are committed to providing a welcoming and inclusive environment for all contributors.
228216

229217
**Please read our complete [Code of Conduct](CODE_OF_CONDUCT.md)** for full details on our standards and expectations.
230218

231-
### Copyright
232-
219+
### License File Headers
233220
All code files that are added to this repository must include the appropriate NVIDIA copyright header:
234221

235222
```python
@@ -240,7 +227,6 @@ All code files that are added to this repository must include the appropriate NV
240227
Use `make update-license-headers` to add headers automatically.
241228

242229
## Getting Help
243-
244230
Need help with your contribution?
245231

246232
- **Documentation**: Check the [documentation](docs/) and [AGENTS.md](AGENTS.md) for additional information

0 commit comments

Comments
 (0)