Fix pulling default provider name from config file and use it (#36)

Author: nabinchha

src/data_designer/config/default_model_settings.py

@@ -1,8 +1,11 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 
+
+from functools import lru_cache
 import logging
-from typing import Literal
+from pathlib import Path
+from typing import Any, Literal, Optional
 
 from .models import InferenceParameters, ModelConfig, ModelProvider
 from .utils.constants import (
@@ -70,18 +73,19 @@ def get_default_model_configs() -> list[ModelConfig]:
     if MODEL_CONFIGS_FILE_PATH.exists():
         config_dict = load_config_file(MODEL_CONFIGS_FILE_PATH)
         if "model_configs" in config_dict:
-            logger.info(f"♻️ Using default model configs from {str(MODEL_CONFIGS_FILE_PATH)!r}")
             return [ModelConfig.model_validate(mc) for mc in config_dict["model_configs"]]
     raise FileNotFoundError(f"Default model configs file not found at {str(MODEL_CONFIGS_FILE_PATH)!r}")
 
 
 def get_default_providers() -> list[ModelProvider]:
-    if MODEL_PROVIDERS_FILE_PATH.exists():
-        config_dict = load_config_file(MODEL_PROVIDERS_FILE_PATH)
-        if "providers" in config_dict:
-            logger.info(f"♻️ Using default model providers from {str(MODEL_PROVIDERS_FILE_PATH)!r}")
-            return [ModelProvider.model_validate(p) for p in config_dict["providers"]]
-    raise FileNotFoundError(f"Default model providers file not found at {str(MODEL_PROVIDERS_FILE_PATH)!r}")
+    config_dict = _get_default_providers_file_content(MODEL_PROVIDERS_FILE_PATH)
+    if "providers" in config_dict:
+        return [ModelProvider.model_validate(p) for p in config_dict["providers"]]
+    return []
+
+
+def get_default_provider_name() -> Optional[str]:
+    return _get_default_providers_file_content(MODEL_PROVIDERS_FILE_PATH).get("default")
 
 
 def resolve_seed_default_model_settings() -> None:
@@ -104,3 +108,11 @@ def resolve_seed_default_model_settings() -> None:
         save_config_file(
             MODEL_PROVIDERS_FILE_PATH, {"providers": [p.model_dump() for p in get_builtin_model_providers()]}
         )
+
+
+@lru_cache(maxsize=1)
+def _get_default_providers_file_content(file_path: Path) -> dict[str, Any]:
+    """Load and cache the default providers file content."""
+    if file_path.exists():
+        return load_config_file(file_path)
+    raise FileNotFoundError(f"Default model providers file not found at {str(file_path)!r}")

src/data_designer/engine/model_provider.py

@@ -64,10 +64,12 @@ def get_provider(self, name: str | None) -> ModelProvider:
             raise UnknownProviderError(f"No provider named {name!r} registered")
 
 
-def resolve_model_provider_registry(model_providers: list[ModelProvider]) -> ModelProviderRegistry:
+def resolve_model_provider_registry(
+    model_providers: list[ModelProvider], default_provider_name: str | None = None
+) -> ModelProviderRegistry:
     if len(model_providers) == 0:
         raise NoModelProvidersError("At least one model provider must be defined")
     return ModelProviderRegistry(
         providers=model_providers,
-        default=model_providers[0].name,
+        default=default_provider_name or model_providers[0].name,
     )

src/data_designer/interface/data_designer.py

@@ -10,6 +10,7 @@
 from data_designer.config.config_builder import DataDesignerConfigBuilder
 from data_designer.config.default_model_settings import (
     get_default_model_configs,
+    get_default_provider_name,
     get_default_providers,
     resolve_seed_default_model_settings,
 )
@@ -22,6 +23,8 @@
 from data_designer.config.seed import LocalSeedDatasetReference
 from data_designer.config.utils.constants import (
     DEFAULT_NUM_RECORDS,
+    MODEL_CONFIGS_FILE_PATH,
+    MODEL_PROVIDERS_FILE_PATH,
 )
 from data_designer.config.utils.info import InterfaceInfo
 from data_designer.config.utils.io_helpers import write_seed_dataset
@@ -96,7 +99,9 @@ def __init__(
             else init_managed_blob_storage(str(blob_storage_path))
         )
         self._model_providers = model_providers or self.get_default_model_providers()
-        self._model_provider_registry = resolve_model_provider_registry(self._model_providers)
+        self._model_provider_registry = resolve_model_provider_registry(
+            self._model_providers, get_default_provider_name()
+        )
 
     @staticmethod
     def make_seed_reference_from_file(file_path: str | Path) -> LocalSeedDatasetReference:
@@ -248,6 +253,7 @@ def get_default_model_configs(self) -> list[ModelConfig]:
         Returns:
             List of default model configurations.
         """
+        logger.info(f"♻️ Using default model configs from {str(MODEL_CONFIGS_FILE_PATH)!r}")
         return get_default_model_configs()
 
     def get_default_model_providers(self) -> list[ModelProvider]:
@@ -256,6 +262,7 @@ def get_default_model_providers(self) -> list[ModelProvider]:
         Returns:
             List of default model providers.
         """
+        logger.info(f"♻️ Using default model providers from {str(MODEL_PROVIDERS_FILE_PATH)!r}")
         return get_default_providers()
 
     def set_buffer_size(self, buffer_size: int) -> None:

tests/config/test_default_model_settings.py

@@ -13,6 +13,7 @@
     get_builtin_model_providers,
     get_default_inference_parameters,
     get_default_model_configs,
+    get_default_provider_name,
     get_default_providers,
     resolve_seed_default_model_settings,
 )
@@ -95,6 +96,28 @@ def test_get_default_providers_path_does_not_exist():
             get_default_providers()
 
 
+def test_get_default_provider_name_with_default_key(tmp_path: Path):
+    providers_file_path = tmp_path / "providers.yaml"
+    providers_file_path.write_text(
+        json.dumps(dict(providers=[p.model_dump() for p in get_builtin_model_providers()], default="nvidia"))
+    )
+    with patch("data_designer.config.default_model_settings.MODEL_PROVIDERS_FILE_PATH", new=providers_file_path):
+        assert get_default_provider_name() == "nvidia"
+
+
+def test_get_default_provider_name_without_default_key(tmp_path: Path):
+    providers_file_path = tmp_path / "providers.yaml"
+    providers_file_path.write_text(json.dumps({"providers": [p.model_dump() for p in get_builtin_model_providers()]}))
+    with patch("data_designer.config.default_model_settings.MODEL_PROVIDERS_FILE_PATH", new=providers_file_path):
+        assert get_default_provider_name() is None
+
+
+def test_get_default_provider_name_path_does_not_exist():
+    with patch("data_designer.config.default_model_settings.MODEL_PROVIDERS_FILE_PATH", new=Path("non_existent_path")):
+        with pytest.raises(FileNotFoundError, match=r"Default model providers file not found at 'non_existent_path'"):
+            get_default_provider_name()
+
+
 def test_get_nvidia_api_key():
     with patch("data_designer.config.utils.visualization.os.getenv", return_value="nvidia_api_key"):
         assert get_nvidia_api_key() == "nvidia_api_key"