default to composite resolver (#47)

Author: nabinchha

src/data_designer/engine/secret_resolver.py

@@ -57,6 +57,15 @@ def __init__(self, resolvers: Sequence[SecretResolver]):
             raise SecretResolutionError("Must provide at least one SecretResolver to CompositeResolver")
         self._resolvers = resolvers
 
+    @property
+    def resolvers(self) -> Sequence[SecretResolver]:
+        """Get the sequence of resolvers in this composite resolver.
+
+        Returns:
+            Sequence of SecretResolver instances used to resolve secrets.
+        """
+        return self._resolvers
+
     def resolve(self, secret: str) -> str:
         errors = []
         for resolver in self._resolvers:

src/data_designer/interface/data_designer.py

@@ -44,7 +44,12 @@
     HfHubSeedDatasetDataStore,
     LocalSeedDatasetDataStore,
 )
-from data_designer.engine.secret_resolver import EnvironmentResolver, SecretResolver
+from data_designer.engine.secret_resolver import (
+    CompositeResolver,
+    EnvironmentResolver,
+    PlaintextResolver,
+    SecretResolver,
+)
 from data_designer.interface.errors import (
     DataDesignerGenerationError,
     DataDesignerProfilingError,
@@ -87,10 +92,10 @@ def __init__(
         artifact_path: Path | str | None = None,
         *,
         model_providers: list[ModelProvider] | None = None,
-        secret_resolver: SecretResolver = EnvironmentResolver(),
+        secret_resolver: SecretResolver | None = None,
         blob_storage_path: Path | str | None = None,
     ):
-        self._secret_resolver = secret_resolver
+        self._secret_resolver = secret_resolver or CompositeResolver([EnvironmentResolver(), PlaintextResolver()])
         self._artifact_path = Path(artifact_path) if artifact_path is not None else Path.cwd() / "artifacts"
         self._buffer_size = DEFAULT_BUFFER_SIZE
         self._blob_storage = (
@@ -276,6 +281,15 @@ def get_default_model_providers(self) -> list[ModelProvider]:
         logger.info(f"♻️ Using default model providers from {str(MODEL_PROVIDERS_FILE_PATH)!r}")
         return get_default_providers()
 
+    @property
+    def secret_resolver(self) -> SecretResolver:
+        """Get the secret resolver used by this DataDesigner instance.
+
+        Returns:
+            The SecretResolver instance handling credentials and secrets.
+        """
+        return self._secret_resolver
+
     def set_buffer_size(self, buffer_size: int) -> None:
         """Set the buffer size for dataset generation.
 

tests/interface/test_data_designer.py

@@ -15,7 +15,7 @@
 from data_designer.config.processors import DropColumnsProcessorConfig
 from data_designer.config.seed import LocalSeedDatasetReference
 from data_designer.engine.model_provider import ModelProvider
-from data_designer.engine.secret_resolver import PlaintextResolver
+from data_designer.engine.secret_resolver import CompositeResolver, EnvironmentResolver, PlaintextResolver
 from data_designer.interface.data_designer import DataDesigner
 from data_designer.interface.errors import (
     DataDesignerGenerationError,
@@ -51,6 +51,18 @@ def test_init_with_custom_secret_resolver(stub_artifact_path, stub_model_provide
     assert designer is not None
 
 
+def test_init_with_default_composite_secret_resolver(stub_artifact_path, stub_model_providers):
+    """Test DataDesigner initialization with default composite secret resolver."""
+    designer = DataDesigner(artifact_path=stub_artifact_path, model_providers=stub_model_providers)
+    assert designer is not None
+    assert isinstance(designer.secret_resolver, CompositeResolver)
+    # Verify the composite resolver is properly configured with the expected resolvers
+    resolvers = designer.secret_resolver.resolvers
+    assert len(resolvers) == 2
+    assert isinstance(resolvers[0], EnvironmentResolver)
+    assert isinstance(resolvers[1], PlaintextResolver)
+
+
 def test_init_with_string_path(stub_artifact_path, stub_model_providers):
     """Test DataDesigner accepts string paths."""
     designer = DataDesigner(artifact_path=str(stub_artifact_path), model_providers=stub_model_providers)