Modify test helper to make assert statements

Author: mikeknep

src/data_designer/plugins/testing/__init__.py

@@ -1,8 +1,8 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 
-from data_designer.plugins.testing.utils import is_valid_plugin
+from data_designer.plugins.testing.utils import assert_valid_plugin
 
 __all__ = [
-    is_valid_plugin.__name__,
+    assert_valid_plugin.__name__,
 ]

src/data_designer/plugins/testing/utils.py

@@ -6,10 +6,6 @@
 from data_designer.plugins.plugin import Plugin
 
 
-def is_valid_plugin(plugin: Plugin) -> bool:
-    if not isinstance(plugin.config_cls, ConfigBase):
-        return False
-    if not isinstance(plugin.task_cls, ConfigurableTask):
-        return False
-
-    return True
+def assert_valid_plugin(plugin: Plugin) -> None:
+    assert issubclass(plugin.config_cls, ConfigBase), "Plugin config class is not a subclass of ConfigBase"
+    assert issubclass(plugin.task_cls, ConfigurableTask), "Plugin task class is not a subclass of ConfigurableTask"

tests/plugins/test_plugin.py

@@ -10,6 +10,7 @@
 from data_designer.plugins.errors import PluginLoadError
 from data_designer.plugins.plugin import Plugin, PluginType
 from data_designer.plugins.testing.examples import MODULE_NAME, ValidTestConfig, ValidTestTask
+from data_designer.plugins.testing.utils import assert_valid_plugin
 
 
 @pytest.fixture
@@ -130,6 +131,32 @@ def test_validation_fails_with_invalid_modules() -> None:
             plugin_type=PluginType.COLUMN_GENERATOR,
         )
 
+    with pytest.raises(PluginLoadError, match="Could not find class"):
+        Plugin(
+            task_class_name=f"{MODULE_NAME}.ValidTestTask",
+            config_class_name=f"{MODULE_NAME}.NotADefinedClass",
+            plugin_type=PluginType.COLUMN_GENERATOR,
+        )
+
+
+def test_helper_utility_identifies_invalid_classes() -> None:
+    """Test the helper utility provides deeper validation of config classes."""
+    valid_plugin = Plugin(
+        task_class_name=f"{MODULE_NAME}.ValidTestTask",
+        config_class_name=f"{MODULE_NAME}.ValidTestConfig",
+        plugin_type=PluginType.COLUMN_GENERATOR,
+    )
+    assert_valid_plugin(valid_plugin)
+
+    plugin_with_improper_task_class_type = Plugin(
+        task_class_name=f"{MODULE_NAME}.ValidTestConfig",
+        config_class_name=f"{MODULE_NAME}.ValidTestConfig",
+        plugin_type=PluginType.COLUMN_GENERATOR,
+    )
+    with pytest.raises(AssertionError):
+        assert_valid_plugin(plugin_with_improper_task_class_type)
+
+
 
 # =============================================================================
 # Integration Tests