Skip to content

Commit d7d6e9c

Browse files
committed
add get required resources method to base column generator
1 parent bb6c088 commit d7d6e9c

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

src/data_designer/engine/column_generators/generators/base.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ def generate(self, data: pd.DataFrame) -> pd.DataFrame: ...
5656
@abstractmethod
5757
def generate(self, data: DataT) -> DataT: ...
5858

59+
@staticmethod
60+
def get_required_resources() -> list[ResourceType]:
61+
return []
62+
5963
def log_pre_generation(self) -> None:
6064
"""A shared method to log info before the generator's `generate` method is called.
6165

src/data_designer/engine/column_generators/generators/expression.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from __future__ import annotations
55

66
import logging
7-
from typing import TYPE_CHECKING
87

98
import pandas as pd
109

@@ -18,18 +17,10 @@
1817
from data_designer.engine.processing.ginja.environment import WithJinja2UserTemplateRendering
1918
from data_designer.engine.processing.utils import deserialize_json_values
2019

21-
if TYPE_CHECKING:
22-
from data_designer.engine.resources.resource_provider import ResourceType
23-
24-
2520
logger = logging.getLogger(__name__)
2621

2722

2823
class ExpressionColumnGenerator(WithJinja2UserTemplateRendering, ColumnGenerator[ExpressionColumnConfig]):
29-
@staticmethod
30-
def get_required_resources() -> list[ResourceType]:
31-
return []
32-
3324
@staticmethod
3425
def metadata() -> GeneratorMetadata:
3526
return GeneratorMetadata(

src/data_designer/engine/column_generators/generators/validation.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
)
2222
from data_designer.engine.dataset_builders.utils.concurrency import ConcurrentThreadExecutor
2323
from data_designer.engine.errors import DataDesignerRuntimeError
24-
from data_designer.engine.resources.resource_provider import ResourceType
2524
from data_designer.engine.validators import (
2625
BaseValidator,
2726
LocalCallableValidator,
@@ -47,10 +46,6 @@ def get_validator_from_params(validator_type: ValidatorType, validator_params: V
4746

4847

4948
class ValidationColumnGenerator(ColumnGenerator[ValidationColumnConfig]):
50-
@staticmethod
51-
def get_required_resources() -> list[ResourceType]:
52-
return []
53-
5449
@staticmethod
5550
def metadata() -> GeneratorMetadata:
5651
return GeneratorMetadata(

0 commit comments

Comments
 (0)