-
Notifications
You must be signed in to change notification settings - Fork 51
chore: (FTUE ) updated display pipeline for builder and interface like objects #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the DCO ✍️ ✅ |
| return get_default_nvidia_model_configs() | ||
|
|
||
| def get_default_model_providers(self) -> list[ModelProvider]: | ||
| return [get_default_nvidia_model_provider()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will be updated in the next PR to pull from yml config files written by the cli.
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
|
recheck |
src/data_designer/config/models.py
Outdated
| alias="reasoning", | ||
| model="nvidia/llama-3.3-nemotron-super-49b-v1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirit93 – please chime in with thoughts on default models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We all chatted offline to support multiple provider (nvidia, opena) to start with along with their model configs. It' all handled in this commit:
Behaviors:
- This displays the default model providers (nvidia and and openai). If the required API key cannot be found, it will show it's missing.
data_designer = DataDesigner()
data_designer.info.display(InfoType.MODEL_PROVIDERS)
- This displays the available default model configs based on which API keys were detected. In this example, only openai model configs were shown because nvidia api key could not be found. There's a warning that gets printed out as well.
config_builder = DataDesignerConfigBuilder(model_configs=data_designer.get_default_model_configs())
config_builder.info.display(InfoType.MODEL_CONFIGS)
- If both nvidia and openai models cannot be found, we'll see warnings for each of the keys not being found + additional warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnnygreco if you are cool with the above, let's get this merged in. We can further tweak the model names, etc in follow up PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds good. We can tweak in follow ups. One thought I had was to have get_default_model_configs take an argument ("nvidia" or "openai"), which we can default to "nvidia". That way we can only raise a warning for the appropriate API key when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea sounds good I'll get that in the next PR.
| @abstractmethod | ||
| def get_default_model_configs(self) -> list[ModelConfig]: ... | ||
|
|
||
| @abstractmethod | ||
| def get_default_model_providers(self) -> list[ModelProvider]: ... | ||
|
|
||
| @property | ||
| @abstractmethod | ||
| def info(self) -> InterfaceInfo: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeknep just want to make sure you are are of these changes for the nmp dd client.
Part 1 of FTUE