Update README.md - Added background and usage example #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyw
reviewed
Oct 1, 2025
README.md
Outdated
|
|
||
| ### Why They Matter | ||
|
|
||
| Shampoo optimizers have demonstrated significant practical impact in large-scale language model training. Most notably, they were used to train the **Kimi K2 model** ([arXiv:2507.20534](https://arxiv.org/abs/2507.20534)), showcasing their effectiveness at scale. These optimizers can: |
Contributor
There was a problem hiding this comment.
Kimi used Muon. And it is also debatable whether it is shampoo.
Contributor
There was a problem hiding this comment.
We probably should just change to emerging optimizers to not exclude any future ones.
Contributor
Author
There was a problem hiding this comment.
Updated to mention emerging optimizers
README.md
Outdated
|
|
||
| ### Optimizers Included | ||
|
|
||
| This project focuses on the following Shampoo class optimizers: |
Contributor
|
@sbhavani could you address the CI failure? @snowmanwwg plz also review. |
Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
…matrix-based preconditioning' Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
skyw
reviewed
Oct 7, 2025
Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com>
skyw
approved these changes
Oct 7, 2025
Contributor
|
/ok to test e5a78dd |
Contributor
|
/ok to test 0408134 |
pablo-garay
pushed a commit
that referenced
this pull request
Oct 10, 2025
* Update README with background, usage examples Signed-off-by: Santosh Bhavani <sbhavani@nvidia.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.