Adding "spectral clipped" weight decay to be used together with matrix-based preconditioning optimizers #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
\ok to test 64c9aa9 |
mkhona-nvidia
force-pushed
the
mkhona/spectral_weight_decay
branch
from
fe42f31 to
a170f44
Compare
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
mkhona-nvidia
force-pushed
the
mkhona/spectral_weight_decay
branch
from
4f7d2c2 to
e46e361
Compare
Contributor
Author
|
\ok to test e46e361 |
Signed-off-by: mikail <[email protected]>
Contributor
|
/ok to test b6cc6b6 |
skyw
approved these changes
Oct 3, 2025
mkhona-nvidia
added a commit
to mkhona-nvidia/Emerging-Optimizers
that referenced
this pull request
Oct 7, 2025
…ased preconditioning optimizers (NVIDIA-NeMo#38) * added spectral clipping from previous PR Signed-off-by: mikail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @leloykun's spectral clipping algorithm
Also updated Polar Express Newton-schulz coefficients to their "stable" version as described by the paper, excluding the last entry