Feature: skip CI when docs-only label added #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-garay
force-pushed
the
pablo-garay_add_docs-only_feature_capability2
branch
from
37ce778 to
9be8686
Compare
Contributor
Author
|
/ok to test 9be8686 |
ko3n1g
reviewed
Oct 8, 2025
.github/workflows/cicd-main.yml
Outdated
Comment on lines
256
to
264
| codecov-placeholder: | ||
| name: codecov/patch | ||
| needs: [pre-flight] | ||
| if: needs.pre-flight.outputs.docs_only == 'true' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: codecov_placeholder | ||
| run: | | ||
| echo "This is a placeholder status check for when no tests are ran but the codecov status is expected" |
There was a problem hiding this comment.
I would recommend using MBridge's approach instead: https://github.com/NVIDIA-NeMo/Megatron-Bridge/blob/main/.github/workflows/cicd-main.yml#L181
For GitHub, a status check passes under two conditions: When it passes (trivial) and when it's being skipped. So in the scenarios where we skip the codecov-placeholder, GitHub will accept codecov/patch as a valid status check. If the actual job in line 206 failed, the skipped one will take precedence and GitHub will allow merging
Contributor
Author
There was a problem hiding this comment.
made changes, PTAL
pablo-garay
force-pushed
the
pablo-garay_add_docs-only_feature_capability2
branch
from
6cc2093 to
76e0edc
Compare
Contributor
Author
|
/ok to test 76e0edc |
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
pablo-garay
force-pushed
the
pablo-garay_add_docs-only_feature_capability2
branch
from
97895f2 to
9fad6c5
Compare
Contributor
Author
|
/ok to test 9fad6c5 |
pablo-garay
force-pushed
the
pablo-garay_add_docs-only_feature_capability2
branch
from
9fad6c5 to
ac0310d
Compare
Contributor
Author
|
/ok to test ac0310d |
ko3n1g
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.