Add dependencies to pyproject and uv.lock #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
ko3n1g
previously approved these changes
Sep 16, 2025
skyw
previously approved these changes
Sep 16, 2025
docker/Dockerfile.ci
Outdated
| uv sync --link-mode symlink --locked --all-groups \ | ||
| --no-install-package absl-py \ | ||
| --no-install-package torch \ | ||
| --no-install-package torchvision \ |
Contributor
There was a problem hiding this comment.
I'm not familiar with uv. Does this mean install or not install torchvision?
Torchvision is not needed.
Contributor
Author
There was a problem hiding this comment.
It means NOT to install. I'll remove it anyway because it's not needed here. I copied these exclusions from sone other projects where we need to prevent uv from overriding the torch dependencies that are already installed.
Contributor
Author
There was a problem hiding this comment.
uv works well when we're installing all the dependencies from scratch. However, in the Pytorch container, we need to tell uv to not install the already installed dependencies we care about
Signed-off-by: Charlie Truong <[email protected]>
skyw
approved these changes
Sep 18, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dependencies to pyproject and uv.lock