Add kl shampoo support to SOAP #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyw
force-pushed
the
skyw/kl_shampoo_dev
branch
from
b9357f8 to
25200cc
Compare
Contributor
Author
|
@mkhona-nvidia we need to think about how to test this. |
mkhona-nvidia
requested changes
Oct 17, 2025
Contributor
mkhona-nvidia
left a comment
mkhona-nvidia
left a comment
There was a problem hiding this comment.
Suggestion: instead in the init make a kronecker_factor_update_fn and assign either update_kronecker_factors or update_kronecker_factors_kl_shampoo
need to think about how to deal with that extra argument eigenbasis_list
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
skyw
force-pushed
the
skyw/kl_shampoo_dev
branch
from
54f7720 to
4123d53
Compare
Contributor
Author
|
/ok to test 4123d53 |
Signed-off-by: Hao Wu <[email protected]>
Contributor
Author
|
/ok to test f3509f4 |
mkhona-nvidia
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.