-
Notifications
You must be signed in to change notification settings - Fork 10
Scion optimizer #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scion optimizer #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mikail <[email protected]>
…Optimizer" This reverts commit 09012a3. Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
ff42aa8 to
e6db31e
Compare
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
…02.07529 Signed-off-by: mikail <[email protected]>
skyw
reviewed
Nov 4, 2025
|
Amazing, thanks @mkhona-nvidia! Could you please also
|
Signed-off-by: mikail <[email protected]>
skyw
reviewed
Nov 4, 2025
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
skyw
requested changes
Nov 5, 2025
Contributor
skyw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes needed. otherwise LGTM
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
Signed-off-by: mikail <[email protected]>
skyw
approved these changes
Nov 5, 2025
Contributor
|
/ok to test 5521b58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Scion.
The main change is the parametrization to allow Franke-Wolfe. We now DO NOT use weight decay and instead use step size (i.e. the learning rate) and spectral radius, with the unit_rms choice for width scaling