Pre first release cleanup #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Contributor
Author
|
/ok to test fb57fe5 |
mkhona-nvidia
previously approved these changes
Nov 5, 2025
Signed-off-by: Hao Wu <[email protected]>
skyw
force-pushed
the
skyw/prerelease_cleanup
branch
from
fb57fe5 to
9190b79
Compare
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
skyw
force-pushed
the
skyw/prerelease_cleanup
branch
from
9190b79 to
5144a6e
Compare
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
emerging_optimizers/orthogonalized_optimizers/orthogonalized_optimizer.py
Show resolved
Hide resolved
| WeightDecayT = Literal["decoupled", "independent", "l2"] | ||
|
|
||
|
|
||
| class WeightDecayMixin: |
Contributor
There was a problem hiding this comment.
What is the reason for this to be a class rather than a set of functions that are chosen based on arguments?
Contributor
Author
There was a problem hiding this comment.
weight decay is a function highly coupled with optimizer, and shared among a lot of optim subclass.
Thought about a optimizer based class with this function and make everyone inherit from it, but not all of our optimizers use the same base.
Signed-off-by: Hao Wu <[email protected]>
Signed-off-by: Hao Wu <[email protected]>
Contributor
Author
|
/ok to test 832ae49 |
Signed-off-by: Hao Wu <[email protected]>
mkhona-nvidia
approved these changes
Nov 7, 2025
chtruong814
approved these changes
Nov 7, 2025
Contributor
|
/ok to test da5be01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkhona-nvidia @FDecaYed please take a look, there will be another doc only clean up before we making a release, after which things changing things would become maintenance burden.
@mkhona-nvidia coverage of scalar optimizers and soap with adaptative criteria is low, would be good to improve. It can also be done after release, so not mandatory.