Conversation
Signed-off-by: Abhishree <abhishreetm@gmail.com>
ko3n1g
reviewed
Aug 12, 2025
Collaborator
ko3n1g
left a comment
ko3n1g
left a comment
There was a problem hiding this comment.
Thanks for adding this. Please also update the lock file by running uv lock in the workdir
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
Author
Thank you @ko3n1g added in the latest commit. |
Contributor
Author
|
/ok to test 0cbaac3 |
ko3n1g
approved these changes
Aug 13, 2025
ko3n1g
pushed a commit
that referenced
this pull request
Sep 22, 2025
Signed-off-by: Abhishree <abhishreetm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins nvidia-lm-eval to 25.6.1 as the latest 25.7.1 version leads to error.
ModuleNotFoundError: No module named 'core_evals.lm_evaluation_harness.input'We should pin the version until 25.7.1 nvidia-lm-eval is fixed by the CompEval team.
cc: @marta-sd
Also this is an issue with latest 25.07 nemo fw container since it has nvidia-lm-eval 25.7.1. So all future nemo fw container builds should use nvidia-lm-eval 25.6.1 until latest nvidia-lm-eval is fixed