ci: Enable initial unit tests and remove auto-formatting in PRs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
chtruong814
requested review from
ko3n1g,
pablo-garay and
thomasdhc
as code owners
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
ko3n1g
reviewed
May 27, 2025
.github/copy-pr-bot.yaml
Outdated
| - maanug-nv | ||
| auto_sync_draft: false | ||
| auto_sync_ready: true | ||
| auto_sync_ready: false |
Contributor
Author
There was a problem hiding this comment.
So I removed the Run CICD label need for now and I thought we were thinking better to use /ok to test? Or do you think we should just let any commit start running the CI? Open to either tbh. Early enough that we can wait to see if it's a pain without it.
ko3n1g
reviewed
May 27, 2025
Comment on lines
192
to
+197
| NUM_CANCELLED=$(gh run view $RUN_ID --json jobs -q '[.jobs[] | select(.conclusion == "cancelled") | .name] | length') | ||
|
|
||
| if [[ $NUM_FAILED -eq 0 && $NUM_CANCELLED -eq 0 && ("$HAS_LABEL" == "true" || "$IS_SCHEDULED" == "true") ]]; then | ||
| if [[ $NUM_FAILED -eq 0 && $NUM_CANCELLED -eq 0 ]]; then |
Contributor
There was a problem hiding this comment.
Just a headsup this might not work currently. IIRC, gh cli doesn't have access to a repo with the anonymous github.token token
Contributor
Author
There was a problem hiding this comment.
It would just silently fail? We have the PAT in the repo as a secret. Maybe we just use that?
ko3n1g
previously approved these changes
May 27, 2025
Contributor
ko3n1g
left a comment
ko3n1g
left a comment
There was a problem hiding this comment.
LGTM. Easy review since this is just one of the early onboarding PRs. However, one question and one remark.
Signed-off-by: Charlie Truong <[email protected]>
ko3n1g
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable initial unit tests and remove auto-formatting in PRs
/ok to testto run the CI job