Enabling TP Comm Overlap and Packed Sequencing Configs for LLAMA3 70B…#2247
Merged
Enabling TP Comm Overlap and Packed Sequencing Configs for LLAMA3 70B…#2247
Conversation
… LoRa Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com>
Contributor
📝 WalkthroughWalkthroughConfiguration modifications to enable communication overlap and CUDA graph compatibility for Llama 3 models across multiple hardware platforms (gb200, gb300, h100). Changes affect llama3_70b variants for both SFT and LORA training modes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
malay-nagda
previously approved these changes
Feb 6, 2026
Contributor
Author
|
/ok to test 89d9b2a |
auto-merge was automatically disabled
February 9, 2026 19:09
Pull Request is not mergeable
Contributor
Author
|
/ok to test c39b8a8 |
Signed-off-by: Raghav Hrishikeshan Mukundan <102543536+rhmukundan@users.noreply.github.com>
ko3n1g
pushed a commit
that referenced
this pull request
Feb 10, 2026
#2247) Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com> Signed-off-by: Raghav Hrishikeshan Mukundan <102543536+rhmukundan@users.noreply.github.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
rhmukundan
added a commit
that referenced
this pull request
Feb 10, 2026
#2247) Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com> Signed-off-by: Raghav Hrishikeshan Mukundan <102543536+rhmukundan@users.noreply.github.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
sowmen
pushed a commit
to sowmen/Megatron-Bridge
that referenced
this pull request
Feb 11, 2026
NVIDIA-NeMo#2247) Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com> Signed-off-by: Raghav Hrishikeshan Mukundan <102543536+rhmukundan@users.noreply.github.com> Signed-off-by: sowmen <sowmendipta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling TP Comm Overlap if TP > 1 (for GB200 and H100) and packed sequencing configs (for GB200)
Summary by CodeRabbit