Update LLAMA3 70B LoRa Base Configs for GB300, GB200 and H100#2265
Open
rhmukundan wants to merge 2 commits intomainfrom
Open
Update LLAMA3 70B LoRa Base Configs for GB300, GB200 and H100#2265rhmukundan wants to merge 2 commits intomainfrom
rhmukundan wants to merge 2 commits intomainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThis change modifies Llama3 70B LoRA configuration settings for GB300, GB200, and H100 hardware platforms. Updates include adjusting tensor/pipeline/context parallelism dimensions and recomputation parameters across base configs and their variants through replace() calls. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com>
6b69798 to
31d7bcf
Compare
Contributor
Author
|
/ok to test 16aa00e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit