Skip to content

[build] Add missing GHA tests#2269

Open
cuichenx wants to merge 4 commits intomainfrom
chcui/add_missing_tests
Open

[build] Add missing GHA tests#2269
cuichenx wants to merge 4 commits intomainfrom
chcui/add_missing_tests

Conversation

@cuichenx
Copy link
Contributor

@cuichenx cuichenx commented Feb 6, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Expanded continuous integration functional test matrix to include validation for Ministral3, Gemma VL, Llama CUDA graphs, and Qwen VL model variants, along with new utilities testing. This enhancement increases parallel test coverage and strengthens overall compatibility validation across configurations.

Signed-off-by: Chen Cui <chcui@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

New CI/CD test matrix entries are added to the functional test workflow for Ministral3, Gemma VL, Llama CUDA graphs, Qwen VL, and utilities. These additions expand parallel test coverage across multiple models and recipes without altering existing workflow logic.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/cicd-main.yml
Added 6 new test matrix entries: L2_Launch_models_ministral3, L2_Launch_recipes_gemma_vl, L2_Launch_recipes_llama_cuda_graphs, L2_Launch_recipes_ministral3, L2_Launch_recipes_qwen_vl, and L2_Launch_utils to expand functional test coverage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains minor CI/CD configuration changes adding test matrix entries for existing functionality, not affecting code logic or application behavior.
Title check ✅ Passed The title '[build] Add missing GHA tests' directly relates to the changeset, which adds missing GitHub Actions tests to the CI/CD workflow.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chcui/add_missing_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/cicd-main.yml:
- Line 403: The matrix includes a duplicate job entry
"L2_Launch_recipes_llama_cuda_graphs" which will run twice; open the matrix
where the `script:` entries are defined and remove the redundant
`L2_Launch_recipes_llama_cuda_graphs` line so that only a single matrix job with
that script name remains (keep the instance that matches the intended
placement/context and delete the other duplicate).

Signed-off-by: Chen Cui <chcui@nvidia.com>
@cuichenx cuichenx changed the title Add missing GHA tests [build] Add missing GHA tests Feb 6, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants