Model fp8 initialization sync #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think you will need to rebase this on main for updating the CI checks. Other than that, LGTM |
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
ananthsub
force-pushed
the
fp8-model-init
branch
from
8654eaa to
40fa865
Compare
Contributor
Author
|
/ok to test e17f10d |
@ananthsub, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
hemildesai
approved these changes
Jun 13, 2025
Contributor
Author
|
/ok to test 40fa865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep in sync with https://github.com/NVIDIA/Megatron-LM/blob/cde60ce22ecd621f032744d24d0fbdc960f50493/megatron/training/training.py#L1075-L1080
NVIDIA/Megatron-LM@062c833