Ci Fix black version #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
ananthsub
requested review from
chtruong814,
ko3n1g,
pablo-garay and
thomasdhc
as code owners
Signed-off-by: Ananth Subramaniam <[email protected]>
ko3n1g
approved these changes
Jun 4, 2025
Contributor
ko3n1g
left a comment
ko3n1g
left a comment
There was a problem hiding this comment.
Heads up that we’d want to switch to ruff soon, but your fix still makes sense for the meantime. Thanks!
Contributor
Author
|
/ok to test 4944c21 |
yaoyu-33
pushed a commit
that referenced
this pull request
Jul 10, 2025
…de (#39) Signed-off-by: Terry Kong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep consistency with https://github.com/NVIDIA/NeMo/blob/main/requirements/requirements_test.txt#L1
Fix errors like this in CI: https://github.com/NVIDIA-NeMo/NeMo-LM/actions/runs/15447703917/job/43481697759?pr=31#step:9:23