[peft] Port walking utils for peft integration #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ok to test a9e2dcf |
hemildesai
reviewed
Jun 4, 2025
ananthsub
changed the title
Closed
hemildesai
previously approved these changes
Jun 5, 2025
Contributor
Author
|
/ok to test 4efe02c |
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
ananthsub
force-pushed
the
peft-walk-utils
branch
from
4efe02c to
ca3763f
Compare
Signed-off-by: Ananth Subramaniam <[email protected]>
Contributor
Author
|
/ok to test 0a34450 |
hemildesai
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily for peft integration. This ports https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/fn/base.py and associated tests over to nemo lm