Implement Duplex Speech-to-text model and rebase #15092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Pasad <[email protected]>
… possibly inflated results Signed-off-by: Ankita Pasad <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: Ankita Pasad <[email protected]>
…-sysprompt support training and inference for data with system prompt
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
…e unnecessary code Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
zhehuaichen
reviewed
Nov 27, 2025
Collaborator
zhehuaichen
left a comment
zhehuaichen
left a comment
There was a problem hiding this comment.
Thanks for getting this started!
|
|
||
|
|
||
| @data_type_parser(["s2s_duplex_overlap_as_s2s_duplex"]) | ||
| def read_s2s_duplex_overlap_as_s2s_duplex(config) -> tuple[CutSet, bool]: |
Collaborator
There was a problem hiding this comment.
@pzelasko do you think it is ok to continue growing the size of this file or should we create a separate file for s2s specifics
Collaborator
There was a problem hiding this comment.
let's grow it and refactor it to smaller files later
… add recent fixes Signed-off-by: kevinhu <[email protected]>
Collaborator
Author
|
Resolved comments, and finished another pass of the code to brush up the code by: 1) removing debug code, and 2) add necessary updates since last rebased (e.g. speech cutoff fix). Some areas to discuss before I make changes:
PTAL @zhehuaichen |
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu-nv <[email protected]>
Signed-off-by: kevinhu-nv <[email protected]>
kevinhu-nv
changed the title
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Merge duplex STT changes to NeMo main.
Collection: speechlm2
Changelog
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information