[TTS][MagpieTTS] Add longform capability to do_tts method by subhankar-ghosh · Pull Request #15241 · NVIDIA-NeMo/NeMo

subhankar-ghosh · 2025-12-30T05:00:59Z

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

…on raised in special method Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

…nto magpietts_os_longform

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

…nto magpietts_os_longform

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

github-actions · 2026-01-05T09:25:33Z

[🤖]: Hi @subhankar-ghosh 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

nemo/collections/tts/models/magpietts.py

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

…o into magpietts_os_longformapi

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

github-actions · 2026-01-08T06:40:15Z

[🤖]: Hi @subhankar-ghosh 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

github-actions · 2026-01-09T15:47:12Z

[🤖]: Hi @subhankar-ghosh 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

…o#15241) * Longform TTS using magpietts Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> * Apply isort and black reformatting Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com> * Using LongformDecoderState in LongForm Magpietts Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> * Apply isort and black reformatting Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com> * Potential fix for code scanning alert no. 16815: Non-standard exception raised in special method Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Update nemo/collections/tts/data/text_to_speech_dataset.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Update nemo/collections/tts/models/magpietts.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Update nemo/collections/tts/models/magpietts.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Update nemo/collections/tts/data/text_to_speech_dataset.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Combining Inference runner, using data classes in longform Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> * Apply isort and black reformatting Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com> * make LongFormTTSInferenceDataset a subclass of MagpieTTSDataset Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> * Apply isort and black reformatting Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com> * Update nemo/collections/tts/models/magpietts.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Update nemo/collections/tts/models/magpietts.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * Remove redundant code from inference.py Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> * Adding longform test cases. Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> * Adding longform to do_tts Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> --------- Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> Co-authored-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>

subhankar-ghosh and others added 23 commits December 19, 2025 02:13

Longform TTS using magpietts

44c4644

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Apply isort and black reformatting

335007f

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

Using LongformDecoderState in LongForm Magpietts

e3584d8

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Using LongformDecoderState in LongForm Magpietts

eff4703

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Apply isort and black reformatting

73ddc3d

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

Potential fix for code scanning alert no. 16815: Non-standard excepti…

d2714a7

…on raised in special method Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Update nemo/collections/tts/data/text_to_speech_dataset.py

f7fce00

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Update nemo/collections/tts/models/magpietts.py

132434b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Update nemo/collections/tts/models/magpietts.py

8a4e144

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Update nemo/collections/tts/data/text_to_speech_dataset.py

0f41d39

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Combining Inference runner, using data classes in longform

312f127

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Merge branch 'magpietts_os_longform' of github.com:NVIDIA-NeMo/NeMo i…

bd187b5

…nto magpietts_os_longform

Apply isort and black reformatting

577eff9

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

make LongFormTTSInferenceDataset a subclass of MagpieTTSDataset

a8610d8

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

make LongFormTTSInferenceDataset a subclass of MagpieTTSDataset

9e139c4

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Apply isort and black reformatting

fe64ea8

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

Update nemo/collections/tts/models/magpietts.py

e6a248d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Update nemo/collections/tts/models/magpietts.py

294439e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>

Remove redundant code from inference.py

1e9004b

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Merge branch 'magpietts_os_longform' of github.com:NVIDIA-NeMo/NeMo i…

99ffb47

…nto magpietts_os_longform

Adding longform test cases.

7faab9e

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Adding longform to do_tts

4d4d2a3

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Resolve merge conflicts with main

cc511b0

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

subhankar-ghosh requested a review from blisc December 30, 2025 05:00

subhankar-ghosh added TTS Run CICD labels Dec 30, 2025

chtruong814 added Run CICD and removed Run CICD labels Dec 30, 2025

subhankar-ghosh enabled auto-merge (squash) December 30, 2025 05:01

chtruong814 temporarily deployed to test December 30, 2025 05:03 — with GitHub Actions Inactive

Apply isort and black reformatting

0e9a9aa

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

subhankar-ghosh requested a review from blisc January 5, 2026 07:42

subhankar-ghosh added the Run CICD label Jan 5, 2026

subhankar-ghosh temporarily deployed to test January 5, 2026 07:43 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 5, 2026

blisc requested changes Jan 6, 2026

View reviewed changes

nemo/collections/tts/models/magpietts.py Show resolved Hide resolved

subhankar-ghosh added 2 commits January 7, 2026 07:18

Add tests for _needs_longform_inference method

7ca57cc

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

Merge branch 'magpietts_os_longformapi' of github.com:NVIDIA-NeMo/NeM…

73f8dd9

…o into magpietts_os_longformapi

subhankar-ghosh added the Run CICD label Jan 7, 2026

Apply isort and black reformatting

7655690

Signed-off-by: subhankar-ghosh <subhankar-ghosh@users.noreply.github.com>

chtruong814 added Run CICD and removed Run CICD labels Jan 7, 2026

chtruong814 temporarily deployed to test January 7, 2026 15:21 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 8, 2026

subhankar-ghosh requested a review from blisc January 8, 2026 15:22

rebase main

2d6d0d0

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

subhankar-ghosh added the Run CICD label Jan 8, 2026

subhankar-ghosh had a problem deploying to test January 8, 2026 19:23 — with GitHub Actions Error

Bug fix

d25d2e8

Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>

chtruong814 added Run CICD and removed Run CICD labels Jan 8, 2026

chtruong814 temporarily deployed to test January 8, 2026 21:27 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 9, 2026

blisc approved these changes Jan 9, 2026

View reviewed changes

subhankar-ghosh merged commit e566867 into main Jan 9, 2026
141 checks passed

subhankar-ghosh deleted the magpietts_os_longformapi branch January 9, 2026 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[TTS][MagpieTTS] Add longform capability to do_tts method#15241

[TTS][MagpieTTS] Add longform capability to do_tts method#15241
subhankar-ghosh merged 31 commits intomainfrom
magpietts_os_longformapi

subhankar-ghosh commented Dec 30, 2025

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

subhankar-ghosh commented Dec 30, 2025

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants