cp: Remove nlp module #15258
Merged
cp: Remove nlp module #15258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove nlp.parts collection Signed-off-by: dimapihtar <[email protected]> * remove nemo legacy import Signed-off-by: dimapihtar <[email protected]> * remove nlp.parts collection Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * move nlp_overrides Signed-off-by: dimapihtar <[email protected]> * fix styl Signed-off-by: dimapihtar <[email protected]> * remove extra scripts Signed-off-by: dimapihtar <[email protected]> * remove extra test Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]> Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
* move tokenizer_utils Signed-off-by: dimapihtar <[email protected]> * remove tokenizer_utils Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * remove extra import Signed-off-by: dimapihtar <[email protected]> * move vocab file name Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * remove HF imports Signed-off-by: dimapihtar <[email protected]> * remove hyena submodule Signed-off-by: dimapihtar <[email protected]> * remove transformer submodule Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * remove .py files Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * remove .py files Signed-off-by: dimapihtar <[email protected]> * remove .py files Signed-off-by: dimapihtar <[email protected]> * remove .py files Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * remove nlp.modules.megatron Signed-off-by: dimapihtar <[email protected]> * remove nlp collection Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix style Signed-off-by: dimapihtar <[email protected]> * fix code style Signed-off-by: dimapihtar <[email protected]> * fix code style Signed-off-by: dimapihtar <[email protected]> * fix code style Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix code style Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * remove unused function Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * fix unit tests Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * fix imports Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * fix import Signed-off-by: dimapihtar <[email protected]> * fix code style Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]> Signed-off-by: Charlie Truong <[email protected]>
* remove HeteronymClassificationModel Signed-off-by: Jason <[email protected]> * pylint Signed-off-by: Jason <[email protected]> --------- Signed-off-by: Jason <[email protected]> Signed-off-by: Charlie Truong <[email protected]>
chtruong814
requested review from
ko3n1g,
pablo-garay and
thomasdhc
as code owners
github-actions
bot
added
core
Collaborator
Author
ko3n1g
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Cherry-picks these PRs that remove the NLP module:
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information