Add missing data subcommand for super3#103
Open
mvanhorn wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
Open
Add missing data subcommand for super3#103mvanhorn wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
mvanhorn wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
The super3 command group imports a `data` package that was not checked in (referenced in _typer_group.py line 26). This adds the complete data package mirroring the nano3 data package structure with import and prep subcommands, pointing to the super3 recipe data_prep scripts. Also fixes the .gitignore negation path for nano3/data (was missing `commands/` directory) and adds super3/data negation. Fixes NVIDIA-NeMo#100 Signed-off-by: Matt Van Horn <matt@mattvanhorn.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #100
The
super3command group imports adatapackage (_typer_group.pyline 26) that was not checked in with the super3 training recipes release. This adds the completedata/package mirroring the existingnano3/data/structure:data/import_/- Import pretrain, SFT, and RL data as W&B artifactsdata/prep/- Data preparation commands for pretrain, SFT, and RL stagesAll files follow the nano3 data package pattern exactly, with paths updated to reference super3 recipe
data_prep.pyscripts.Also fixes the
.gitignorenegation for the nano3 data directory (was!src/nemotron/cli/nano3/data/, corrected to!src/nemotron/cli/commands/nano3/data/) and adds the super3 negation. This gitignore issue is likely why the data package was not included in the original super3 release.Changes
src/nemotron/cli/commands/super3/data/(mirroring nano3 pattern).gitignore(fix nano3 negation path, add super3 negation)Test plan
nemotron super3 data --helpshows prep and import subcommandsnemotron super3 data prep --helpshows pretrain, sft, rl subcommandsnemotron super3 data import --helpshows pretrain, sft, rl subcommandsruff checkandruff format --checkpassThis contribution was developed with AI assistance (Claude Code).