fix: Fix grad norm metric in mcore path#1426
Merged
Conversation
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
terrykong
reviewed
Oct 24, 2025
Collaborator
terrykong
left a comment
terrykong
left a comment
There was a problem hiding this comment.
any chance to add a unit test for this?
would it be sufficient to test case when using micro_bs=1 mini_bs=2 and micro_bs=2 mini_bs=2 and check grad norm equal?
ashors1
reviewed
Oct 24, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Contributor
Author
Added in c951fb9 |
yfw
added
CI:L1
terrykong
approved these changes
Oct 27, 2025
chtruong814
pushed a commit
that referenced
this pull request
Oct 27, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
lbliii
pushed a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Previously, the grad_norm metric in mcore was added as a microbatch metric and then summed during reporting, meaning the value we were reporting was being multiplied by the number of microbatches. This PR fixes this issue by removing grad_norm from the microbatch metrics and is more consistent with how we report grad norm in the dtensor path.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information