-
Notifications
You must be signed in to change notification settings - Fork 233
chore: add nanov3 lora sft recipe to doc #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a reference link to a full configuration example for SFT LoRA setup in the documentation guide's policy section, immediately following example usage without introducing any functional changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/guides/sft.md`:
- Line 237: There is a mismatch between the link text and the actual filename in
the markdown link: the display shows "sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml"
but the linked path points to "sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml"; fix by
making the display text match the real file name (or update the path if the
intended file was 2n4g), i.e., update the markdown link text or the target so
both use the same exact filename "sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml" (or
"sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml" if that is the correct file) in the
docs/guides/sft.md link line.
- Line 237: The link text and target mismatch: the text references
sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml while the URL points to
sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml; pick the intended recipe (either 2n4g or
2n8g) and make the link text and the URL consistent in the sentence referencing
the example (update either the displayed text or the URL so both use the same
filename, e.g., change the text to sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml if
that is the desired file or update the URL to
sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml to match the current text).
Signed-off-by: ruit <[email protected]>
Signed-off-by: ruit <[email protected]>
Signed-off-by: ruit <[email protected]>
95b4838 to
81e3dc7
Compare
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.