Closed
Conversation
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis change implements support for custom logits processors in the vLLM generation pipeline. It extends configuration schema to specify logits processor classes and environment variables, adds dynamic class loading during worker initialization, and integrates per-sample thinking budget arguments into generation requests through metadata injection. Changes
Sequence Diagram(s)sequenceDiagram
participant Config as Policy Config
participant Worker as VLLMWorker
participant Rollout as Rollout Generator
participant Engine as vLLM Engine
Config->>Worker: Initialize with logits_processors config
Worker->>Worker: Load custom logits processor classes<br/>(module_path:ClassName)
Worker->>Worker: Set environment variables from<br/>logits_processor_env_vars
Worker->>Engine: Initialize with loaded logits_processors
Rollout->>Rollout: Parse global logits processor defaults<br/>from policy config
Rollout->>Rollout: For each row with thinking_budget:<br/>build per-sample vllm_xargs
Rollout->>Engine: Submit request with per-sample args<br/>in extra_body metadata
Engine->>Engine: Apply logits processors with<br/>per-sample budget overrides
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
allow custom logits process in vllm
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit