Skip to content

Conversation

@Kipok
Copy link
Collaborator

@Kipok Kipok commented Jan 29, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated core component versions to latest releases for improved stability and compatibility.
    • Refined test evaluation criteria to reflect enhanced baseline performance.

✏️ Tip: You can customize this high-level summary in your review settings.

smahdavi4 and others added 30 commits December 9, 2025 15:30
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
@Kipok Kipok requested a review from gwarmstrong January 29, 2026 21:59
@Kipok
Copy link
Collaborator Author

Kipok commented Jan 29, 2026

slurm tests are passing on both A100 and H100 gpus. Blackwell has problems with specific containers / models (e.g. gpt-oss + vllm 0.14.1 is broken), but let's fix those later

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 29, 2026

Additional Comments (2)

dockerfiles/README.md
Missing section for building vllm image. The PR removes the vllm section from the README (which mentioned v0.10.2), but the project now uses a Dockerfile for vllm (v0.14.1 as shown in Dockerfile.vllm). Add back a section explaining that vllm uses a Dockerfile with audio dependencies.

## Building sglang image

We directly use official `lmsysorg/sglang:v0.5.8` image.

## Building vllm image

We use official `vllm/vllm-openai:v0.14.1` image with additional `vllm[audio]` dependencies.

docs/basics/index.md
Documentation references outdated vllm version v0.10.1.1. This should be updated to match the new configuration which uses dockerfile:dockerfiles/Dockerfile.vllm instead of a direct image reference.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

This PR updates container image references across configuration and test files, including trtllm (1.0.0 → 1.3.0rc1), sglang (v0.5.4 → v0.5.8), and vllm (v0.14.0 → v0.14.1). Additionally, it switches vllm to use a Dockerfile reference and adjusts evaluation metric accuracy thresholds.

Changes

Cohort / File(s) Summary
Container Image Upgrades
cluster_configs/example-local.yaml, nemo_skills/__init__.py, tests/gpu-tests/test-local.yaml
Updated trtllm from 1.0.0 to 1.3.0rc1 and sglang from v0.5.4 to v0.5.8 across multiple configuration files.
VLLm Configuration
cluster_configs/example-local.yaml, dockerfiles/Dockerfile.vllm
Switched vllm reference from direct tag (v0.10.1.1) to Dockerfile reference and updated vllm base image from v0.14.0 to v0.14.1.
Documentation
dockerfiles/README.md
Updated trtllm and sglang image references in README; removed dedicated vllm section.
Evaluation Metrics
tests/slurm-tests/qwen3_4b_evals/check_results.py
Widened accuracy ranges for tool calling metrics: live\_relevance (70.0–100.0), overall\_multi\_turn (20.0–33.0), and adjusted non\_live\_ast lower bound (85.0–84.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

run GPU tests

Suggested reviewers

  • activatedgeek
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade containers' accurately summarizes the main change across all modified files: updating container image versions (trtllm, vllm, sglang) throughout the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kipok Kipok merged commit b986304 into main Jan 30, 2026
6 checks passed
@Kipok Kipok deleted the igitman/sglang-update branch January 30, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants