-
Notifications
You must be signed in to change notification settings - Fork 139
Upgrade containers #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade containers #1198
Conversation
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
…itman/sglang-update
Signed-off-by: Sadegh Mahdavi <[email protected]>
Signed-off-by: Sadegh Mahdavi <[email protected]>
…itman/sglang-update
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
…eMo-Skills into smahdavi/nemo-rl-update
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Igor Gitman <[email protected]>
|
slurm tests are passing on both A100 and H100 gpus. Blackwell has problems with specific containers / models (e.g. gpt-oss + vllm 0.14.1 is broken), but let's fix those later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Additional Comments (2)
|
📝 WalkthroughWalkthroughThis PR updates container image references across configuration and test files, including trtllm (1.0.0 → 1.3.0rc1), sglang (v0.5.4 → v0.5.8), and vllm (v0.14.0 → v0.14.1). Additionally, it switches vllm to use a Dockerfile reference and adjusts evaluation metric accuracy thresholds. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.