Skip to content

Conversation

@shantoislamdev
Copy link

@shantoislamdev shantoislamdev commented Jan 30, 2026

Description

Adds missing dependency latex2sympy2_extended to requirements/main.txt.

Problem

The package latex2sympy2_extended is imported by nemo_skills/evaluation/math_grader.py but was not listed in the project requirements. This causes a ModuleNotFoundError when users install the package and attempt to run math evaluation pipelines (e.g., GSM8K, AIME, or any benchmark using the math metric type).

Import chain:

nemo_skills/pipeline/eval.pynemo_skills/pipeline/summarize_results.pynemo_skills/evaluation/metrics/compute_metrics.pynemo_skills/evaluation/metrics/math_metrics.pynemo_skills/evaluation/math_grader.pyfrom latex2sympy2_extended import NormalizationConfig, normalize_latex

Solution

Add latex2sympy2_extended to requirements/main.txt after language-data to maintain alphabetical ordering.

Testing

After this change, users can successfully:

  1. Install the package: pip install -e .
  2. Run math evaluations without ModuleNotFoundError

Impact

  • Breaking: No
  • User-facing: Yes (fixes broken installation for math evaluation)
  • Dependencies: Adds one package to installation requirements

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to enhance system capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

Added the latex2sympy2_extended dependency to the project requirements without modifying existing entries. This extends the installation set to include math evaluation capabilities via LaTeX to SymPy conversion.

Changes

Cohort / File(s) Summary
Dependency Addition
requirements/main.txt
Added latex2sympy2_extended to project dependencies for extended LaTeX to SymPy conversion support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a missing dependency (latex2sympy2_extended) to requirements/main.txt to fix a ModuleNotFoundError in math evaluation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shantoislamdev shantoislamdev force-pushed the fix/add-latex2sympy2-dependency branch from bc397b3 to b29185d Compare January 30, 2026 11:18
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

This package is imported by nemo_skills/evaluation/math_grader.py
but was not listed in requirements/main.txt, causing ModuleNotFoundError
when running math evaluation pipelines.

Fixes missing dependency for math evaluation normalization.

Signed-off-by: shanroislamdev <[email protected]>
@shantoislamdev shantoislamdev force-pushed the fix/add-latex2sympy2-dependency branch from b29185d to caee78d Compare January 30, 2026 11:22
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@shantoislamdev shantoislamdev changed the title Fix ModuleNotFoundError in math evaluation Fix: Add missing latex2sympy2_extended to requirements Jan 30, 2026
@Kipok
Copy link
Collaborator

Kipok commented Jan 30, 2026

this should already be installed as a dependency of math-verify. @shantoislamdev could you please share the command you're running that causes this error?

@shantoislamdev
Copy link
Author

ah right, makes sense. math-verify already pulls it in. saw it imported in math_grader but not listed explicitly in requirements and I assumed it was a missing top-level dependency, didn't think to check transitive deps. my bad, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants