-
Notifications
You must be signed in to change notification settings - Fork 139
Fix: Add missing latex2sympy2_extended to requirements #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add missing latex2sympy2_extended to requirements #1201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
📝 WalkthroughWalkthroughAdded the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bc397b3 to
b29185d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
This package is imported by nemo_skills/evaluation/math_grader.py but was not listed in requirements/main.txt, causing ModuleNotFoundError when running math evaluation pipelines. Fixes missing dependency for math evaluation normalization. Signed-off-by: shanroislamdev <[email protected]>
b29185d to
caee78d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
|
this should already be installed as a dependency of math-verify. @shantoislamdev could you please share the command you're running that causes this error? |
|
ah right, makes sense. math-verify already pulls it in. saw it imported in math_grader but not listed explicitly in requirements and I assumed it was a missing top-level dependency, didn't think to check transitive deps. my bad, closing! |
Description
Adds missing dependency
latex2sympy2_extendedto requirements/main.txt.Problem
The package
latex2sympy2_extendedis imported by nemo_skills/evaluation/math_grader.py but was not listed in the project requirements. This causes aModuleNotFoundErrorwhen users install the package and attempt to run math evaluation pipelines (e.g., GSM8K, AIME, or any benchmark using the math metric type).Import chain:
Solution
Add
latex2sympy2_extendedtorequirements/main.txtafterlanguage-datato maintain alphabetical ordering.Testing
After this change, users can successfully:
pip install -e .ModuleNotFoundErrorImpact
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.