-
Notifications
You must be signed in to change notification settings - Fork 147
Fix CI disk space for Docker image builds #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove irrelevant files to free disk space on Ubuntu runners. Add docker builder prune between image builds to prevent "no space left on device" during sandbox image load. Signed-off-by: George Armstrong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
📝 WalkthroughWalkthroughCI workflow and Dockerfile updated: workflow replaces macOS-specific disk cleanup with Linux-focused removals and adds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: George Armstrong <[email protected]>
8da2f5a to
6bdf6dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
dockerfiles/Dockerfile.sandbox
Outdated
|
|
||
| # Use the base image with Python 3.10 and Flask | ||
| FROM tiangolo/uwsgi-nginx-flask:python3.10 | ||
| ARG CACHEBUST=2026-02-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CACHEBUST ARG invalidates the entire Docker cache on every build since it's placed early in the Dockerfile. This defeats the purpose of the --cache-from and --cache-to flags in .github/workflows/tests.yml:63-64,82-83.
If this was added only for testing purposes (as suggested by the commit message "to test full uncached CI build"), it should be removed before merging.
If cache invalidation is needed permanently, consider:
- Moving it later in the Dockerfile (after stable layers)
- Passing it as a build-arg with a timestamp:
--build-arg CACHEBUST=$(date +%s) - Removing it entirely if the
docker builder prune -fon line 72 oftests.ymlalready solves the disk space issue
Signed-off-by: George Armstrong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Summary
docker builder prune -fbetween image builds to prevent "no space left on device" during sandbox image loadSummary by CodeRabbit