Skip to content

Checkout magpie branch instead of main - #14813

Merged
rfejgin merged 11 commits into
NVIDIA-NeMo:magpietts_2508from
blisc:magpietts_2508_ciupdate
Sep 27, 2025
Merged

Checkout magpie branch instead of main#14813
rfejgin merged 11 commits into
NVIDIA-NeMo:magpietts_2508from
blisc:magpietts_2508_ciupdate

Conversation

@blisc

@blisc blisc commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>

@rfejgin rfejgin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor comments but nothing that should block merging, so we can get CI running.

@@ -227,11 +226,9 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some places use checkout@v2, others @v4 or @v5, not sure if there's a reason for it (or how much it matters)

run: |
chmod -R u+rwX ${{ github.run_id }}
echo "noop"
# - name: Noop

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping the commented code around to have a reference of what changed from main? otherwise I guess we can delete it.

@rfejgin
rfejgin merged commit d7fee58 into NVIDIA-NeMo:magpietts_2508 Sep 27, 2025
63 checks passed
@blisc
blisc deleted the magpietts_2508_ciupdate branch October 3, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants