-
Notifications
You must be signed in to change notification settings - Fork 76
Add kCuda backend support for MM+RS stream lowering #5761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a250a75 to
d5a36ee
Compare
Greptile SummaryThis PR extends the stream parallel type lowering pass to support the Key Changes
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Lowering as Stream Parallel Lowering
participant Backend as Communicator Backend
participant P2P as P2P Communication
participant Wait as Wait Handler
Lowering->>Backend: Check communicator_backend
alt kNccl Backend
Backend->>P2P: StartCoalescing
P2P->>P2P: Create RECV
P2P->>P2P: Create SEND
P2P->>P2P: EndCoalescing
P2P->>Wait: Wait(end_coalescing)
else kCuda Backend
Backend->>P2P: ShareMemHandles(recv, send)
alt P2pProtocol::Get
P2P->>P2P: SEND first
P2P->>P2P: RECV second
else P2pProtocol::Put
P2P->>P2P: RECV first
P2P->>P2P: SEND second
end
P2P->>Wait: Wait(recv) - immediate
P2P->>Wait: Wait(send) - deferred to epilogue
else Unsupported
Backend->>Lowering: NVF_THROW
end
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
487bc2b to
162c0c7
Compare
|
Thanks for the suggestions @wujingyue |
| if_sending_to_self->elseBody().pushBack(send); | ||
| break; | ||
| } | ||
| default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
557cbc4 to
49d62fd
Compare
|
!test |
No description provided.