Make the top-level data containers struct for cleaner access patterns.#166
Draft
Make the top-level data containers struct for cleaner access patterns.#166
Conversation
Introduce per-channel serialization for trackers that produce multiple independent data streams (e.g. left/right hand, left/right controller). - Add ITracker::get_record_channels() and channel_index param to ITrackerImpl::serialize() for multi-channel trackers - Update McapRecorder to create separate MCAP channels per sub-channel - HandTracker: serialize each hand individually (delete hands.fbs) - ControllerTracker: split API to get_left_controller()/get_right_controller(), store snapshots directly as structs, update ControllerData schema to hold a single ControllerSnapshot - Update all downstream: plugins, examples, source nodes, tests, bindings
Add XXRecord root_type wrapper tables for MCAP serialization: - HandPoseRecord, ControllerSnapshotRecord, HeadPoseRecord, FullBodyPosePicoRecord, Generic3AxisPedalOutputRecord, LocomotionCommandRecord, FrameMetadataRecord - Rename ControllerData to ControllerSnapshotRecord - Update tracker schema names and binary schema references - Update serialize() methods to pack into Record builders - Add static_assert VT_DATA checks in C++ tests
Clean up the schema and make them structs because we have a top-level table for writing to mcap
nvddr
force-pushed
the
devdeepr/topLevelStruct
branch
from
6883f4f to
57f239f
Compare
Docs previewBuilt docs for this PR are available at: https://NVIDIA.github.io/IsaacTeleop/preview/pr-166/ (It may take a minute to appear after the workflow completes.) |
nvddr
force-pushed
the
devdeepr/createRecordType
branch
2 times, most recently
from
7cda387 to
6f16255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.