Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files were updated: the SPDX copyright year was changed to 2025-2026 and the CMake configuration now includes the Oak camera plugin build flag. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build-ubuntu.yml:
- Line 74: The workflow's CMake invocation uses the wrong option name
(BUILD_OAK_PLUGIN) so the Oak camera plugin won't build; update the Ubuntu
workflow run step to use the correct CMake variable BUILD_PLUGIN_OAK_CAMERA (the
same name used in CMakeLists.txt and the Windows workflow) so the flag is
recognized and the plugin is built.
In @.github/workflows/build-windows.yml:
- Line 79: The CMake option name used in this workflow appears inconsistent:
update the variable to match the canonical CMake option used elsewhere by
confirming whether BUILD_PLUGIN_OAK_CAMERA or BUILD_OAK_PLUGIN is the correct
CMake option (run the same verification script referenced in the other
workflow), then make both workflows use that single verified variable name
(replace BUILD_PLUGIN_OAK_CAMERA in this file with the verified BUILD_OAK_PLUGIN
or vice versa) so the Windows and Ubuntu builds pass the same CMake flag.
| -DCMAKE_C_COMPILER="cl.exe" | ||
| -DCMAKE_CXX_COMPILER="cl.exe" | ||
| -DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded | ||
| -DBUILD_PLUGIN_OAK_CAMERA=ON |
There was a problem hiding this comment.
Verify this is the correct CMake variable name.
This uses BUILD_PLUGIN_OAK_CAMERA while the Ubuntu workflow uses BUILD_OAK_PLUGIN. Please verify which variable name is correct and ensure both workflows use the same variable. See the related comment in build-ubuntu.yml for the verification script.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/build-windows.yml at line 79, The CMake option name used
in this workflow appears inconsistent: update the variable to match the
canonical CMake option used elsewhere by confirming whether
BUILD_PLUGIN_OAK_CAMERA or BUILD_OAK_PLUGIN is the correct CMake option (run the
same verification script referenced in the other workflow), then make both
workflows use that single verified variable name (replace
BUILD_PLUGIN_OAK_CAMERA in this file with the verified BUILD_OAK_PLUGIN or vice
versa) so the Windows and Ubuntu builds pass the same CMake flag.
d0790a6 to
59ebfa6
Compare
59ebfa6 to
444ba49
Compare
Summary by CodeRabbit