Skip to content

enable build oak for github ci#186

Open
shaosu-nvidia wants to merge 1 commit intomainfrom
ssx/camera_recording_oakci
Open

enable build oak for github ci#186
shaosu-nvidia wants to merge 1 commit intomainfrom
ssx/camera_recording_oakci

Conversation

@shaosu-nvidia
Copy link
Contributor

@shaosu-nvidia shaosu-nvidia commented Feb 26, 2026

Summary by CodeRabbit

  • Chores
    • Updated build workflows for Ubuntu and Windows to enable building the Oak camera plugin.
    • Updated copyright year to 2025–2026.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59ebfa6 and 444ba49.

📒 Files selected for processing (2)
  • .github/workflows/build-ubuntu.yml
  • .github/workflows/build-windows.yml

📝 Walkthrough

Walkthrough

Two GitHub Actions workflow files were updated: the SPDX copyright year was changed to 2025-2026 and the CMake configuration now includes the Oak camera plugin build flag.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build-ubuntu.yml, .github/workflows/build-windows.yml
Updated SPDX copyright header to 2025-2026 and added CMake flag -DBUILD_PLUGIN_OAK_CAMERA=ON to enable building the Oak camera plugin in CI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰
Oak bits in YAML, tiny and bright,
Years extended, flags switched right,
CI hums softly, builds take flight,
I hop and cheer through day and night 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'enable build oak for github ci' directly and accurately describes the main changes in the pull request, which add the -DBUILD_PLUGIN_OAK_CAMERA=ON flag to GitHub CI workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ssx/camera_recording_oakci

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/build-ubuntu.yml:
- Line 74: The workflow's CMake invocation uses the wrong option name
(BUILD_OAK_PLUGIN) so the Oak camera plugin won't build; update the Ubuntu
workflow run step to use the correct CMake variable BUILD_PLUGIN_OAK_CAMERA (the
same name used in CMakeLists.txt and the Windows workflow) so the flag is
recognized and the plugin is built.

In @.github/workflows/build-windows.yml:
- Line 79: The CMake option name used in this workflow appears inconsistent:
update the variable to match the canonical CMake option used elsewhere by
confirming whether BUILD_PLUGIN_OAK_CAMERA or BUILD_OAK_PLUGIN is the correct
CMake option (run the same verification script referenced in the other
workflow), then make both workflows use that single verified variable name
(replace BUILD_PLUGIN_OAK_CAMERA in this file with the verified BUILD_OAK_PLUGIN
or vice versa) so the Windows and Ubuntu builds pass the same CMake flag.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13f1b93 and d0790a6.

📒 Files selected for processing (2)
  • .github/workflows/build-ubuntu.yml
  • .github/workflows/build-windows.yml

-DCMAKE_C_COMPILER="cl.exe"
-DCMAKE_CXX_COMPILER="cl.exe"
-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded
-DBUILD_PLUGIN_OAK_CAMERA=ON
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Verify this is the correct CMake variable name.

This uses BUILD_PLUGIN_OAK_CAMERA while the Ubuntu workflow uses BUILD_OAK_PLUGIN. Please verify which variable name is correct and ensure both workflows use the same variable. See the related comment in build-ubuntu.yml for the verification script.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-windows.yml at line 79, The CMake option name used
in this workflow appears inconsistent: update the variable to match the
canonical CMake option used elsewhere by confirming whether
BUILD_PLUGIN_OAK_CAMERA or BUILD_OAK_PLUGIN is the correct CMake option (run the
same verification script referenced in the other workflow), then make both
workflows use that single verified variable name (replace
BUILD_PLUGIN_OAK_CAMERA in this file with the verified BUILD_OAK_PLUGIN or vice
versa) so the Windows and Ubuntu builds pass the same CMake flag.

Copy link
Collaborator

@jiwenc-nv jiwenc-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If CI becomes too slow, we might come back asking for only doing that when OakD plugin is changed. Currently we don't have a very elegant way to doing it.

@shaosu-nvidia shaosu-nvidia force-pushed the ssx/camera_recording_oakci branch from 59ebfa6 to 444ba49 Compare February 27, 2026 01:04
@shaosu-nvidia shaosu-nvidia enabled auto-merge (squash) February 27, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants