Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds explicit dependencies on five Python module targets (deviceio_py, mcap_py, oxr_py, plugin_manager_py, schema_py) to a CMake custom command that generates Python type stubs. This ensures the Python modules are built before the stub generation process begins, enforcing proper build order and synchronization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes stubgen caching by adding explicit dependencies on the compiled pybind11 module files. The stubgen process generates Python type stub files (.pyi) for IDE intellisense by importing the compiled pybind11 modules, so it requires the actual .so files to exist. Without these file-level dependencies, CMake's caching could cause stale stub files when the compiled modules change but the custom command's dependencies aren't properly invalidated.
Changes:
- Added
$<TARGET_FILE:...>dependencies for all 5 pybind11 modules (deviceio_py, mcap_py, oxr_py, plugin_manager_py, schema_py) to the stubgen custom command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit