Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the OpenXR handle management system by replacing a custom OpenXRHandle wrapper class with standard std::unique_ptr, simplifying resource management and leveraging C++ standard library functionality.
Key changes:
- Removed custom
OpenXRHandletemplate class and replaced it withstd::unique_ptrwith appropriate deleters - Refactored helper functions to accept parameters by const reference instead of pointer
- Reorganized member initialization in tracker classes to use initializer lists
- Extracted helper functions into the anonymous namespace for better code organization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/xrio/cpp/inc/xrio/headtracker.hpp | Removed explicit destructor declaration and constructor comment |
| src/core/xrio/cpp/inc/xrio/controllertracker.hpp | Removed explicit destructor declaration and moved hand path members earlier in class definition |
| src/core/xrio/cpp/headtracker.cpp | Refactored constructor to use initializer list and removed destructor implementation |
| src/core/xrio/cpp/controllertracker.cpp | Extracted helper functions, refactored constructor to use initializer list, and removed destructor |
| src/core/oxr_utils/cpp/inc/oxr_utils/oxr_funcs.hpp | Replaced OpenXRHandle with std::unique_ptr and changed function signatures to accept const references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nvddr
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.