Skip to content

Replace OpenXRHandle with std::unique_ptr#21

Merged
nvddr merged 3 commits intomainfrom
aaristarkhov/unique_ptr
Dec 18, 2025
Merged

Replace OpenXRHandle with std::unique_ptr#21
nvddr merged 3 commits intomainfrom
aaristarkhov/unique_ptr

Conversation

@aristarkhovNV
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the OpenXR handle management system by replacing a custom OpenXRHandle wrapper class with standard std::unique_ptr, simplifying resource management and leveraging C++ standard library functionality.

Key changes:

  • Removed custom OpenXRHandle template class and replaced it with std::unique_ptr with appropriate deleters
  • Refactored helper functions to accept parameters by const reference instead of pointer
  • Reorganized member initialization in tracker classes to use initializer lists
  • Extracted helper functions into the anonymous namespace for better code organization

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/core/xrio/cpp/inc/xrio/headtracker.hpp Removed explicit destructor declaration and constructor comment
src/core/xrio/cpp/inc/xrio/controllertracker.hpp Removed explicit destructor declaration and moved hand path members earlier in class definition
src/core/xrio/cpp/headtracker.cpp Refactored constructor to use initializer list and removed destructor implementation
src/core/xrio/cpp/controllertracker.cpp Extracted helper functions, refactored constructor to use initializer list, and removed destructor
src/core/oxr_utils/cpp/inc/oxr_utils/oxr_funcs.hpp Replaced OpenXRHandle with std::unique_ptr and changed function signatures to accept const references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nvddr nvddr merged commit 9399804 into main Dec 18, 2025
4 checks passed
@aristarkhovNV aristarkhovNV deleted the aaristarkhov/unique_ptr branch December 18, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants