feat: adopt parentless queues under a synthetic default root queue #845

gshaibi · 2026-01-06T16:05:28Z

Description

This PR adds support for parentless queues (queues without a parent) by automatically adopting them under a synthetic __default__ root queue.

Changes

Core Logic (`pkg/scheduler/cache/cluster_info/queue.go`)

A synthetic root queue named __default__ is now always created during queue snapshotting
Parentless queues are automatically adopted under this root

Why `default` instead of `default`?

To avoid potential conflicts with user-created queues named "default" (__default__ can't be created by users as it is not a valid resource name in Kubernetes)

Related Issues

Fixes #621

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

Self-reviewed
Added/updated tests (if needed)
Updated documentation (if needed)

Breaking Changes

Additional Notes

github-actions · 2026-01-06T16:37:24Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.09% (-0.20%)	👎

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	89.19% (-1.29%)	37 (-5)	33 (-5)	4	👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

…y in queue handling comments

github-actions · 2026-01-06T19:17:57Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.09% (-0.20%)	👎

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	89.19% (-1.29%)	37 (-5)	33 (-5)	4	👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

github-actions · 2026-01-07T09:01:42Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.09% (-0.20%)	👎

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	89.19% (-1.29%)	37 (-5)	33 (-5)	4	👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

…tion of result map and default parent queue

github-actions · 2026-01-07T10:10:20Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.33% (+0.04%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	90.70% (+0.22%)	43 (+1)	39 (+1)	4	👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

github-actions · 2026-01-07T12:28:52Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.12% (+0.04%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	90.70% (+0.22%)	43 (+1)	39 (+1)	4	👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

github-actions · 2026-01-12T10:27:29Z

📊 Performance Benchmark Results

Comparing PR (shaibi/support-orphan-queues-new) vs main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │            pr-bench.txt            │
                                    │     sec/op     │    sec/op     vs base              │
AllocateAction_SmallCluster-4           107.9m ±  1%   108.3m ± 10%       ~ (p=0.132 n=6)
AllocateAction_MediumCluster-4          135.5m ±  2%   134.4m ±  1%       ~ (p=0.093 n=6)
AllocateAction_LargeCluster-4           226.8m ± 15%   218.1m ±  7%       ~ (p=0.394 n=6)
ReclaimAction_SmallCluster-4            102.9m ±  0%   102.9m ±  0%       ~ (p=0.180 n=6)
ReclaimAction_MediumCluster-4           105.5m ±  0%   105.6m ±  0%       ~ (p=0.937 n=6)
PreemptAction_SmallCluster-4            103.7m ±  0%   103.7m ±  0%       ~ (p=0.818 n=6)
PreemptAction_MediumCluster-4           113.2m ±  0%   113.2m ±  0%       ~ (p=0.485 n=6)
ConsolidationAction_SmallCluster-4      112.6m ±  0%   112.7m ±  0%       ~ (p=0.132 n=6)
ConsolidationAction_MediumCluster-4     197.7m ±  1%   199.0m ±  1%       ~ (p=0.065 n=6)
FullSchedulingCycle_SmallCluster-4      105.3m ±  0%   105.2m ±  0%       ~ (p=0.937 n=6)
FullSchedulingCycle_MediumCluster-4     118.9m ±  1%   119.3m ±  0%  +0.35% (p=0.041 n=6)
FullSchedulingCycle_LargeCluster-4      157.7m ±  1%   158.0m ±  0%       ~ (p=0.093 n=6)
ManyQueues_MediumCluster-4              138.8m ±  1%   138.9m ±  1%       ~ (p=0.818 n=6)
GangScheduling_MediumCluster-4          157.4m ±  1%   157.5m ±  1%       ~ (p=1.000 n=6)
geomean                                 130.3m         130.0m        -0.21%

                                    │ main-bench.txt │            pr-bench.txt             │
                                    │      B/op      │     B/op       vs base              │
AllocateAction_SmallCluster-4           2.083Mi ± 1%    2.086Mi ± 1%       ~ (p=0.240 n=6)
AllocateAction_MediumCluster-4          11.66Mi ± 0%    11.66Mi ± 0%       ~ (p=0.699 n=6)
AllocateAction_LargeCluster-4           41.13Mi ± 0%    41.13Mi ± 0%       ~ (p=0.937 n=6)
ReclaimAction_SmallCluster-4            865.6Ki ± 1%    865.6Ki ± 1%       ~ (p=0.937 n=6)
ReclaimAction_MediumCluster-4           2.737Mi ± 0%    2.737Mi ± 0%       ~ (p=0.818 n=6)
PreemptAction_SmallCluster-4           1004.7Ki ± 0%   1006.0Ki ± 0%       ~ (p=0.485 n=6)
PreemptAction_MediumCluster-4           3.945Mi ± 0%    3.943Mi ± 0%       ~ (p=0.818 n=6)
ConsolidationAction_SmallCluster-4      4.874Mi ± 0%    4.874Mi ± 0%       ~ (p=0.589 n=6)
ConsolidationAction_MediumCluster-4     43.62Mi ± 0%    43.62Mi ± 0%       ~ (p=0.485 n=6)
FullSchedulingCycle_SmallCluster-4      1.331Mi ± 0%    1.339Mi ± 1%       ~ (p=0.093 n=6)
FullSchedulingCycle_MediumCluster-4     6.704Mi ± 0%    6.704Mi ± 0%       ~ (p=0.937 n=6)
FullSchedulingCycle_LargeCluster-4      22.51Mi ± 0%    22.51Mi ± 0%       ~ (p=0.699 n=6)
ManyQueues_MediumCluster-4              15.89Mi ± 0%    15.89Mi ± 0%       ~ (p=0.699 n=6)
GangScheduling_MediumCluster-4          16.84Mi ± 0%    16.84Mi ± 0%       ~ (p=0.394 n=6)
geomean                                 6.115Mi         6.119Mi       +0.06%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            35.06k ± 0%   35.07k ± 0%       ~ (p=0.255 n=6)
AllocateAction_MediumCluster-4           321.4k ± 0%   321.4k ± 0%       ~ (p=0.820 n=6)
AllocateAction_LargeCluster-4            1.385M ± 0%   1.385M ± 0%       ~ (p=0.513 n=6)
ReclaimAction_SmallCluster-4             7.898k ± 0%   7.898k ± 0%       ~ (p=1.000 n=6)
ReclaimAction_MediumCluster-4            24.54k ± 0%   24.54k ± 0%       ~ (p=0.565 n=6)
PreemptAction_SmallCluster-4             10.76k ± 0%   10.76k ± 0%       ~ (p=0.987 n=6)
PreemptAction_MediumCluster-4            37.13k ± 0%   37.13k ± 0%       ~ (p=0.805 n=6)
ConsolidationAction_SmallCluster-4       64.47k ± 0%   64.47k ± 0%       ~ (p=0.472 n=6)
ConsolidationAction_MediumCluster-4      620.6k ± 0%   620.6k ± 0%       ~ (p=0.452 n=6)
FullSchedulingCycle_SmallCluster-4       20.59k ± 0%   20.59k ± 0%       ~ (p=0.574 n=6)
FullSchedulingCycle_MediumCluster-4      171.8k ± 0%   171.8k ± 0%       ~ (p=0.753 n=6)
FullSchedulingCycle_LargeCluster-4       720.2k ± 0%   720.2k ± 0%       ~ (p=0.675 n=6)
ManyQueues_MediumCluster-4               357.6k ± 0%   357.6k ± 0%       ~ (p=0.485 n=6)
GangScheduling_MediumCluster-4           590.2k ± 0%   590.2k ± 0%       ~ (p=0.788 n=6)
geomean                                  107.1k        107.1k       +0.00%

Legend

📈 Negative delta = Performance improvement (faster)
📉 Positive delta = Performance regression (slower)
p-value < 0.05 indicates statistically significant change

Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	       9	 119284998 ns/op	 2209984 B/op	   35076 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107900969 ns/op	 2183476 B/op	   35061 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108233148 ns/op	 2191455 B/op	   35065 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108063560 ns/op	 2183925 B/op	   35067 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108530764 ns/op	 2198607 B/op	   35071 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108292099 ns/op	 2183542 B/op	   35062 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135207906 ns/op	12227863 B/op	  321354 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133694904 ns/op	12225509 B/op	  321355 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134860262 ns/op	12223631 B/op	  321349 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133986077 ns/op	12229686 B/op	  321349 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135157743 ns/op	12225099 B/op	  321355 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133843422 ns/op	12226666 B/op	  321343 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 212390903 ns/op	43126068 B/op	 1385058 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 223342783 ns/op	43123689 B/op	 1385037 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 212786568 ns/op	43123897 B/op	 1385045 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 229427456 ns/op	43130291 B/op	 1385040 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 205263475 ns/op	43122806 B/op	 1385036 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 232806450 ns/op	43138368 B/op	 1385043 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102944306 ns/op	  881682 B/op	    7872 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 103107489 ns/op	  878802 B/op	    7885 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102911482 ns/op	  886351 B/op	    7898 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102999290 ns/op	  890285 B/op	    7899 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102863944 ns/op	  895205 B/op	    7899 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102871155 ns/op	  886455 B/op	    7898 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105394676 ns/op	 2873300 B/op	   24541 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105394023 ns/op	 2869544 B/op	   24540 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105482583 ns/op	 2865620 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105622150 ns/op	 2869540 B/op	   24540 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105622992 ns/op	 2869762 B/op	   24541 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105756654 ns/op	 2873685 B/op	   24542 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103656472 ns/op	 1028823 B/op	   10755 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103637540 ns/op	 1028797 B/op	   10755 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103737531 ns/op	 1028741 B/op	   10755 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103656263 ns/op	 1031565 B/op	   10753 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103719690 ns/op	 1032728 B/op	   10756 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103568326 ns/op	 1032588 B/op	   10756 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113154743 ns/op	 4136713 B/op	   37134 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112976443 ns/op	 4137008 B/op	   37135 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113240458 ns/op	 4136873 B/op	   37135 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113333011 ns/op	 4128144 B/op	   37132 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113294185 ns/op	 4132203 B/op	   37132 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113236122 ns/op	 4132653 B/op	   37134 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112760236 ns/op	 5111640 B/op	   64468 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112674882 ns/op	 5109074 B/op	   64463 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112632898 ns/op	 5121465 B/op	   64468 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112831347 ns/op	 5110077 B/op	   64465 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 108603772 ns/op	 2196451 B/op	   35070 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108025089 ns/op	 2183354 B/op	   35061 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107799614 ns/op	 2183412 B/op	   35062 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108183669 ns/op	 2184968 B/op	   35065 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107842452 ns/op	 2182632 B/op	   35060 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107777256 ns/op	 2184171 B/op	   35064 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137635030 ns/op	12228337 B/op	  321355 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135001450 ns/op	12223729 B/op	  321345 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135272849 ns/op	12226365 B/op	  321361 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135785048 ns/op	12225047 B/op	  321351 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137105808 ns/op	12224282 B/op	  321349 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133766860 ns/op	12227592 B/op	  321350 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 206853822 ns/op	43139356 B/op	 1385050 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 226107079 ns/op	43124305 B/op	 1385045 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 227583081 ns/op	43124460 B/op	 1385050 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 245380291 ns/op	43121081 B/op	 1385023 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       4	 259745702 ns/op	43124094 B/op	 1385059 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 219055113 ns/op	43123840 B/op	 1385038 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102832050 ns/op	  881237 B/op	    7868 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102888995 ns/op	  882818 B/op	    7888 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102930564 ns/op	  890335 B/op	    7899 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102875755 ns/op	  886234 B/op	    7898 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102856625 ns/op	  886551 B/op	    7899 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102885630 ns/op	  891375 B/op	    7898 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105627863 ns/op	 2869388 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105342512 ns/op	 2869572 B/op	   24540 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105573449 ns/op	 2869482 B/op	   24540 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105523079 ns/op	 2873413 B/op	   24541 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105502597 ns/op	 2873476 B/op	   24541 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105530629 ns/op	 2865629 B/op	   24538 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103639098 ns/op	 1032821 B/op	   10757 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103706807 ns/op	 1028764 B/op	   10755 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103563096 ns/op	 1028540 B/op	   10753 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103693240 ns/op	 1028685 B/op	   10755 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103727916 ns/op	 1032724 B/op	   10756 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103597615 ns/op	 1028781 B/op	   10755 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113223885 ns/op	 4132500 B/op	   37133 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113159490 ns/op	 4136761 B/op	   37135 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113231130 ns/op	 4136772 B/op	   37134 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113292645 ns/op	 4136925 B/op	   37135 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113193372 ns/op	 4136918 B/op	   37135 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113120031 ns/op	 4127924 B/op	   37130 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112609199 ns/op	 5111542 B/op	   64467 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112744686 ns/op	 5109890 B/op	   64465 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112567727 ns/op	 5112249 B/op	   64470 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112701249 ns/op	 5129042 B/op	   64468 allocs/op

github-actions · 2026-01-12T10:51:24Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.12% (+0.04%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	90.70% (+0.22%)	43 (+1)	39 (+1)	4	👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

github-actions · 2026-01-12T18:32:41Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info	84.12% (+0.04%)	👍

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/queue.go	90.70% (+0.22%)	43 (+1)	39 (+1)	4	👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go

gshaibi added 2 commits January 6, 2026 18:03

feat: support orphan queues

f5e12e5

Rename

3d36e72

gshaibi changed the title ~~shaibi/support orphan queues new~~ feat: support orphan queues Jan 6, 2026

gshaibi changed the title ~~feat: support orphan queues~~ feat: adopt orphan queues under a synthetic default root queue Jan 6, 2026

changelog

801ac79

gshaibi changed the title ~~feat: adopt orphan queues under a synthetic default root queue~~ feat: adopt parentless queues under a synthetic default root queue Jan 6, 2026

refactor: update terminology from "orphan" to "parentless" for clarit…

88aa5af

…y in queue handling comments

.

805d9eb

gshaibi added 4 commits January 7, 2026 11:11

detach grandparents to enforce temporary 2-level hierarchy limit

d3633af

Added unit test

9063800

test fixes

04c6313

refactor: streamline queue snapshot logic by repositioning initializa…

289dd65

…tion of result map and default parent queue

Merge branch 'main' into shaibi/support-orphan-queues-new

a18080f

enoodle approved these changes Jan 8, 2026

View reviewed changes

Merge branch 'main' into shaibi/support-orphan-queues-new

8d0bb39

Merge branch 'main' into shaibi/support-orphan-queues-new

85f7f7d

gshaibi closed this Jan 13, 2026

feat: adopt parentless queues under a synthetic default root queue #845

feat: adopt parentless queues under a synthetic default root queue #845

Uh oh!

Conversation

gshaibi commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Core Logic (pkg/scheduler/cache/cluster_info/queue.go)

Why __default__ instead of default?

Related Issues

Checklist

Breaking Changes

Additional Notes

Uh oh!

github-actions bot commented Jan 6, 2026

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 6, 2026

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 7, 2026

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 7, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 7, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Benchmark Results

Legend

Uh oh!

github-actions bot commented Jan 12, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Jan 12, 2026

Merging this branch will increase overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gshaibi commented Jan 6, 2026 •

edited

Loading

Core Logic (`pkg/scheduler/cache/cluster_info/queue.go`)

Why `default` instead of `default`?

github-actions bot commented Jan 12, 2026 •

edited

Loading