Skip to content

Conversation

@lhb8125
Copy link
Contributor

@lhb8125 lhb8125 commented Nov 13, 2025

What does this PR do ?

  • replace enable_deepep with use_flex_dispatcher so that deepep and hybridep will be treated in the same way in 1f1b a2a overlap;
  • add some deconstructors in 1f1b a2a overlap to release the references to tensors, which helps to reduce the memory overhead;

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
@lhb8125 lhb8125 requested review from a team as code owners November 13, 2025 05:33
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lhb8125 lhb8125 changed the title fix(moe): Support HybridEP and reduce memory overhead for 1F1B A2A overlap [Draft] fix(moe): Support HybridEP and reduce memory overhead for 1F1B A2A overlap Nov 13, 2025
lhb8125 and others added 9 commits December 1, 2025 22:05
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Pingtian Li <pingtianl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
@lhb8125 lhb8125 requested a review from a team as a code owner December 2, 2025 06:07
@lhb8125
Copy link
Contributor Author

lhb8125 commented Dec 2, 2025

/ok to test 7073437

@ericharper ericharper removed the Expert Review Apply this label to indicate that your PR is ready for expert review. label Jan 5, 2026
@Phlip79 Phlip79 added the dev2main: mbridge dev to main: this PR is needed in main for mbridge label Jan 5, 2026
@Phlip79 Phlip79 enabled auto-merge January 5, 2026 20:40
@lhb8125
Copy link
Contributor Author

lhb8125 commented Jan 6, 2026

/ok to test df960dd

Wohox and others added 6 commits January 5, 2026 17:57
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
@lhb8125
Copy link
Contributor Author

lhb8125 commented Jan 6, 2026

/ok to test 265730f

@Phlip79 Phlip79 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into NVIDIA:main with commit a56a0b0 Jan 6, 2026
45 of 47 checks passed
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Jan 9, 2026
…erlap (NVIDIA#2236)

Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Pingtian Li <pingtianl@nvidia.com>
Co-authored-by: Pingtian Li <pingtianl@nvidia.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jan 9, 2026
…erlap (NVIDIA#2236)

Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Pingtian Li <pingtianl@nvidia.com>
Co-authored-by: Pingtian Li <pingtianl@nvidia.com>
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 10, 2026
…erlap (NVIDIA#2236)

Signed-off-by: Hongbin Liu <hongbinl@nvidia.com>
Signed-off-by: Pingtian Li <pingtianl@nvidia.com>
Co-authored-by: Pingtian Li <pingtianl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: medium dev2main: mbridge dev to main: this PR is needed in main for mbridge Final Review Apply this label to indicate that your PR is ready for final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants