Skip to content

Fix TemporalAsyncCaller pin_memory lifetime in async checkpointing #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lvdunlin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix TemporalAsyncCaller pin_memory lifetime in async checkpointing #2288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdb6bf2
Fix TemporalAsyncCaller pin_memory lifetime in async checkpointing
Nov 18, 2025
89ae0f4
Merge branch 'main' into fix-async-ckpt
dimapihtar Jan 29, 2026
518692f
Merge branch 'main' into fix-async-ckpt
dimapihtar Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions megatron/core/dist_checkpointing/strategies/async_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ class TemporalAsyncCaller(AsyncCaller):
def __init__(self):
self.process: Optional[mp.Process] = None
self.start_time: Optional[float] = None
self.preloaded_holder = None

@_disable_gc()
def schedule_async_call(self, async_req: AsyncRequest) -> None:
Expand All @@ -264,6 +265,7 @@ def schedule_async_call(self, async_req: AsyncRequest) -> None:
# to do the defined action in `async_req.preload_fn` to
# stage GPU tensors to its defined destination
async_fn_args[1] = async_req.preload_fn()
self.preloaded_holder = async_fn_args[1]

rank = torch.distributed.get_rank()
start_sync = time()
Expand Down Expand Up @@ -339,6 +341,7 @@ def close(self, abort=False):
f"after {time() - self.start_time:.2f}s from forking"
)
self.start_time = None
self.preloaded_holder = None

def __del__(self):
pass
Expand Down
Loading