Skip to content

Fuse MLA DOWN projection GEMMs#2960

Closed
cjld wants to merge 3 commits intoNVIDIA:devfrom
cjld:dev
Closed

Fuse MLA DOWN projection GEMMs#2960
cjld wants to merge 3 commits intoNVIDIA:devfrom
cjld:dev

Conversation

@cjld
Copy link
Contributor

@cjld cjld commented Jan 15, 2026

main PR: #3039

What does this PR do ?

add FUSE_QKV_DOWN_PROJ and FUSE_INPUT_LAYERNORM env to control the fusion.
It is ready for profiling, but still need some change to be merged.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@cjld cjld requested review from a team as code owners January 15, 2026 06:17
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 17, 2026
@erhoo82 erhoo82 added the dev2main: mbridge dev to main: this PR is needed in main for mbridge label Jan 20, 2026
@erhoo82 erhoo82 requested a review from yaox12 January 20, 2026 21:21
@erhoo82 erhoo82 removed the dev2main: mbridge dev to main: this PR is needed in main for mbridge label Jan 21, 2026
@cjld cjld closed this Jan 22, 2026
@cjld cjld reopened this Jan 22, 2026
@erhoo82 erhoo82 mentioned this pull request Jan 23, 2026
6 tasks
@cjld cjld closed this Jan 29, 2026
@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants